std: merge definitions of StdioPipes
#146639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
hkBst
approved these changes
Sep 21, 2025
Member
|
r=me with rebase |
All platforms define this structure the same way, so we can just put it in the `process` module directly.
joboet
force-pushed
the
shared-stdiopipes
branch
from
189007f to
87a00f6
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 21, 2025
…imulacrum std: merge definitions of `StdioPipes` All platforms define this structure the same way, so we can just put it in the `process` module directly.
This was referenced Sep 21, 2025
bors
added a commit
that referenced
this pull request
Sep 21, 2025
Rollup of 4 pull requests Successful merges: - #143857 (Port #[macro_export] to the new attribute parsing infrastructure) - #146486 (Improve `core::sync::atomic` coverage) - #146606 (ci: x86_64-gnu-tools: Add `--test-args` regression test) - #146639 (std: merge definitions of `StdioPipes`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Sep 21, 2025
Rollup merge of #146639 - joboet:shared-stdiopipes, r=Mark-Simulacrum std: merge definitions of `StdioPipes` All platforms define this structure the same way, so we can just put it in the `process` module directly.
Muscraft
pushed a commit
to Muscraft/rust
that referenced
this pull request
Sep 24, 2025
…imulacrum std: merge definitions of `StdioPipes` All platforms define this structure the same way, so we can just put it in the `process` module directly.
Muscraft
pushed a commit
to Muscraft/rust
that referenced
this pull request
Sep 24, 2025
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#143857 (Port #[macro_export] to the new attribute parsing infrastructure) - rust-lang#146486 (Improve `core::sync::atomic` coverage) - rust-lang#146606 (ci: x86_64-gnu-tools: Add `--test-args` regression test) - rust-lang#146639 (std: merge definitions of `StdioPipes`) r? `@ghost` `@rustbot` modify labels: rollup
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Oct 9, 2025
…imulacrum std: merge definitions of `StdioPipes` All platforms define this structure the same way, so we can just put it in the `process` module directly.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2025
…ulacrum std: reorganize pipe implementations Currently, there are two distinct types called `AnonPipe` in `std`: * The one used to implement `io::pipe` (in `sys::anonymous_pipe`) * The one used to implement `Stdin`/`Stdout`/`Stderr` (in `sys::pal::pipe`) On Windows, these actually have different semantics, as one of the handles returned by the `sys::pal::pipe` version is opened for asynchronous operation in order to support `read2`, whereas the `sys::anonymous_pipe` version does not do so. Thus the naming is extremely confusing. To fix this, this PR renames the `sys::anonymous_pipe` version of `AnonPipe` to simply `Pipe`, whereas the `sys::pal::pipe` version is now called `ChildPipe`. Additionally, * `sys::anonymous_pipe` is now also just called `sys::pipe`. * On Windows, `sys::pal::pipe` has been moved to `sys::process` and is now called `sys::process::child_pipe`. * On non-Windows platforms, pipe creation is now exclusively handled by `sys::pipe` and `ChildPipe` is defined as a type alias to `Pipe` within `sys::process`. And lastly, the `read2` function (originally in `sys::pal::pipe`) is now called `read_output` and defined by `sys::process`, as (at least on Windows) it is only usable with `ChildPipe`. Includes rust-lang#146639 for convenience.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2025
…ulacrum std: reorganize pipe implementations Currently, there are two distinct types called `AnonPipe` in `std`: * The one used to implement `io::pipe` (in `sys::anonymous_pipe`) * The one used to implement `Stdin`/`Stdout`/`Stderr` (in `sys::pal::pipe`) On Windows, these actually have different semantics, as one of the handles returned by the `sys::pal::pipe` version is opened for asynchronous operation in order to support `read2`, whereas the `sys::anonymous_pipe` version does not do so. Thus the naming is extremely confusing. To fix this, this PR renames the `sys::anonymous_pipe` version of `AnonPipe` to simply `Pipe`, whereas the `sys::pal::pipe` version is now called `ChildPipe`. Additionally, * `sys::anonymous_pipe` is now also just called `sys::pipe`. * On Windows, `sys::pal::pipe` has been moved to `sys::process` and is now called `sys::process::child_pipe`. * On non-Windows platforms, pipe creation is now exclusively handled by `sys::pipe` and `ChildPipe` is defined as a type alias to `Pipe` within `sys::process`. And lastly, the `read2` function (originally in `sys::pal::pipe`) is now called `read_output` and defined by `sys::process`, as (at least on Windows) it is only usable with `ChildPipe`. Includes rust-lang#146639 for convenience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All platforms define this structure the same way, so we can just put it in the
processmodule directly.