-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
crashes: more tests #147857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
crashes: more tests #147857
Conversation
|
@bors try |
This comment has been minimized.
This comment has been minimized.
crashes: more tests try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: x86_64-gnu try-job: dist-i586-gnu-i586-i686-musl try-job: test-various
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 8b4da8e failed: CI. Failed jobs:
|
8069e6a to
b83fb23
Compare
|
@bors try |
This comment has been minimized.
This comment has been minimized.
crashes: more tests try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: x86_64-gnu try-job: dist-i586-gnu-i586-i686-musl try-job: test-various
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 322c270 failed: CI. Failed jobs:
|
b83fb23 to
08138c1
Compare
|
@bors try |
This comment has been minimized.
This comment has been minimized.
crashes: more tests try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: x86_64-gnu try-job: dist-i586-gnu-i586-i686-musl try-job: test-various
|
@bors try |
This comment has been minimized.
This comment has been minimized.
crashes: more tests try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: x86_64-gnu try-job: dist-i586-gnu-i586-i686-musl try-job: test-various
|
This PR changes a file inside |
|
rustbot has assigned @Mark-Simulacrum. Use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, there's 2 crashes tests in here that I think we should drop, but the other ones look good. lmw what you think.
| //@ known-bug: rust-lang/rust#141916 | ||
| //@ edition: 2024 | ||
| #![allow(incomplete_features)] | ||
| #![feature(ergonomic_clones)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: does it make sense to add a crashes test for an incomplete feature? I don't think this would be particularly useful, since the people working said feature is already aware of the ICE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: fmease has an MCVE #143498 (comment), so I rather not add this version with a ton of feature gates...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eh, not in the mood for dealing with aux/flags stuff right now .. :)
|
@rustbot author |
08138c1 to
51f9862
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@bors try |
This comment has been minimized.
This comment has been minimized.
crashes: more tests try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: x86_64-gnu try-job: dist-i586-gnu-i586-i686-musl try-job: test-various
|
The job Click to see the possible cause of the failure (guessed by this bot)For more information how to resolve CI failures of this job, visit this link. |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test for 4187600 failed: CI. Failed jobs:
|
not all of them but at least some of them..
try-job: aarch64-apple
try-job: x86_64-msvc-1
try-job: x86_64-gnu
try-job: dist-i586-gnu-i586-i686-musl
try-job: test-various