Skip to content

WF check lifetime bounds for locals with type params #149389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ShoyuVanilla wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WF check lifetime bounds for locals with type params #149389

ShoyuVanilla wants to merge 1 commit into from
+52 −25

Conversation

@ShoyuVanilla
Copy link
Member

@ShoyuVanilla ShoyuVanilla commented Nov 27, 2025 •
edited by rustbot
Loading

Fixes #115175
Fixes #148854

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 27, 2025
@ShoyuVanilla
Copy link
Member Author

ShoyuVanilla commented Nov 27, 2025

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Nov 27, 2025
@rust-bors
Auto merge of #149389 - ShoyuVanilla:local-region-param-wf, r=<try>
5ce1ef4 
WF check lifetime bounds for locals with type params
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Nov 27, 2025

☀️ Try build successful (CI)
Build commit: 5ce1ef4 (5ce1ef4ffbf1e6d8c09f46fa655ea765bacf4427, parent: cf8a95590a1b768b7711f2631d5b5e3ead464de7)

@ShoyuVanilla
Copy link
Member Author

ShoyuVanilla commented Nov 27, 2025

@bors try

rust-bors bot added a commit that referenced this pull request Nov 27, 2025
@rust-bors
Auto merge of #149389 - ShoyuVanilla:local-region-param-wf, r=<try>
f70ee28 
WF check lifetime bounds for locals with type params
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Nov 27, 2025

☀️ Try build successful (CI)
Build commit: f70ee28 (f70ee28831acc074c109afab32d287057c3eca46, parent: cf8a95590a1b768b7711f2631d5b5e3ead464de7)

@ShoyuVanilla
Copy link
Member Author

ShoyuVanilla commented Nov 28, 2025

@craterbot check

@craterbot
Copy link
Collaborator

craterbot commented Nov 28, 2025

👌 Experiment pr-149389 created and queued.
🤖 Automatically detected try build f70ee28
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 28, 2025
@craterbot
Copy link
Collaborator

craterbot commented Dec 6, 2025

🚧 Experiment pr-149389 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

craterbot commented Dec 7, 2025

🎉 Experiment pr-149389 is completed!
📊 5 regressed and 3 fixed (746168 total)
📊 2051 spurious results on the retry-regessed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-149389/retry-regressed-list.txt ↩

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Dec 7, 2025
@ShoyuVanilla
Copy link
Member Author

ShoyuVanilla commented Dec 8, 2025

@craterbot check crates=https://crater-reports.s3.amazonaws.com/pr-149389/retry-regressed-list.txt

@craterbot
Copy link
Collaborator

craterbot commented Dec 8, 2025

👌 Experiment pr-149389-1 created and queued.
🤖 Automatically detected try build f70ee28
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 8, 2025
@petrochenkov
Copy link
Contributor

petrochenkov commented Dec 12, 2025

@craterbot p=11
All the small runs will complete in a few hours and won't need to wait for a few days until the long beta runs complete.

@craterbot
Copy link
Collaborator

craterbot commented Dec 12, 2025

📝 Configuration of the pr-149389-1 experiment changed.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

craterbot commented Dec 13, 2025

🚧 Experiment pr-149389-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

craterbot commented Dec 13, 2025

🎉 Experiment pr-149389-1 is completed!
📊 0 regressed and 0 fixed (1832 total)
📊 118 spurious results on the retry-regessed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-149389-1/retry-regressed-list.txt ↩

@craterbot craterbot removed the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Dec 13, 2025
@craterbot craterbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 13, 2025
@ShoyuVanilla
Copy link
Member Author

ShoyuVanilla commented Dec 13, 2025

I expected lots of breakages but seems not
r? lcnr

@ShoyuVanilla ShoyuVanilla marked this pull request as ready for review December 13, 2025 12:27
lcnr
lcnr reviewed Dec 14, 2025
View reviewed changes
tests/ui/regions/wf-bound-region-in-local-issue-115175.rs
fn test<T>() {
let _ = None::<Static<T>>;
//~^ ERROR the parameter type `T` may not live long enough
}
Copy link
Contributor

@lcnr lcnr Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also add a test for the unsoundness?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcnr lcnr lcnr left review comments

Assignees

@lcnr lcnr

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Lifetime bounds of Drop aren't checked properly ignored lifetime constraints in type annotations

6 participants

@ShoyuVanilla @rust-log-analyzer @craterbot @petrochenkov @lcnr @rustbot