Crater run for cargo build-dir changes

[ranger-ross]

PR for crater run of rust-lang/cargo#16336
Before running, we should probably get a sanity check from @epage that there is nothing I missed.

See Zulip Thread

r? @Mark-Simulacrum

[rustbot]

Some changes occurred in src/tools/cargo

cc @ehuss

[rustbot]

⚠️ Warning ⚠️

• Some commits in this PR modify submodules.

  If this was not intentional, see I changed a submodule on accident in the rustc dev guide.

[ehuss]

Do you happen to know the crater command you want to run? (The command syntax is documented at https://github.com/rust-lang/crater/blob/master/docs/bot-usage.md)

[Kivooeo]

Let's do try first and then run crater in check-only mode, at least this is how I understand this process

@bors try

[ehuss]

@Kivooeo IIUC, that's not going to be sufficient for this because the new layout is not enabled by default. There may be some special settings like environment variables that will be needed to test this properly. And as for the mode, I suspect we want to build, not check, because we'll want to see if build scripts or proc-macros are doing any shenanigans that are required for linking correctly. (Or maybe test I don't know.)

[rust-bors]

☀️ Try build successful (CI)
Build commit: 3117848 (311784882baa42a9638298cb325fa01a062c9d0f, parent: 198328ad7960b1bece0dc48496bff6c62dd5d339)

[epage]

For this, you can either set -Zbuild-dir-new-layout or CARGO_BUILD_DIR_LAYOUT_V2=true.

Note that x.py can't build with this enabled, see #t-infra/bootstrap > Preparing for the new `build-dir` layout @ 💬

I guess build-only is desirable over check-only to ensure -sys crates link?

A full build-and-test run would help uncover how much people's tests are relying on internals (e.g. I recently fixed rustfmts tests).

[Mark-Simulacrum]

@craterbot run mode=build-and-test start=master#198328ad7960b1bece0dc48496bff6c62dd5d339 end=try#311784882baa42a9638298cb325fa01a062c9d0f+cargoflags=-Zbuild-dir-new-layout crates=random-1000 p=1

Small run just to make sure it mostly works.

[craterbot]

👌 Experiment pr-149852 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[bors]

☔ The latest upstream changes (presumably #149934) made this pull request unmergeable. Please resolve the merge conflicts.