Allow vector types for amdgpu #149994
Merged
Allow vector types for amdgpu #149994
+18
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The amdgpu target uses vector types in various places. The vector types can be used on all architectures, there is no associated target feature that needs to be enabled. The largest vector type found in LLVM intrinsics is `v32i32` (`[32 x i32]`) for mfma intrinsics. Note that while this intrinsic is only supported on some architectures, the vector type itself is supported on all architectures.
rustbot
added
A-run-make
Collaborator
24 tasks
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rustbot
removed
the
S-waiting-on-review
rustbot
added
the
S-waiting-on-review
jieyouxu
approved these changes
Dec 15, 2025
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Dec 15, 2025
Rollup of 7 pull requests Successful merges: - #149744 (test: update duplicate many_digits test to use f64 instead of f32) - #149946 (mir_build: Move and rename code for partitioning match candidates) - #149987 (Move ambient cdb discovery from compiletest to bootstrap) - #149990 (Improve amdgpu docs: Mention device-libs and xnack) - #149994 (Allow vector types for amdgpu) - #149997 (Link POSIX instead of Linux manual for Instant) - #150010 (Correct library linking for hexagon targets in run-make tests) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Dec 15, 2025
Rollup merge of #149994 - Flakebi:amdgpu-vectors, r=jieyouxu Allow vector types for amdgpu The amdgpu target uses vector types in various places. The vector types can be used on all architectures, there is no associated target feature that needs to be enabled. The largest vector type found in LLVM intrinsics is `v32i32` (`[32 x i32]`) for mfma intrinsics. Note that while this intrinsic is only supported on some architectures, the vector type itself is supported on all architectures. Tracking issue: #135024 (I used an empty string to say “does not need a target feature”. If you prefer an `Option` or something like that, I’ll change it.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The amdgpu target uses vector types in various places. The vector types can be used on all architectures, there is no associated target feature that needs to be enabled.
The largest vector type found in LLVM intrinsics is
v32i32([32 x i32]) for mfma intrinsics. Note that while this intrinsic is only supported on some architectures, the vector type itself is supported on all architectures.Tracking issue: #135024
(I used an empty string to say “does not need a target feature”. If you prefer an
Optionor something like that, I’ll change it.)