Support recursive delegation #150024

aerooneqq · 2025-12-15T15:06:52Z

This PR adds support for recursive delegations and is a part of the delegation feature #118212.

r? @petrochenkov

tests/ui/delegation/auxiliary/recursive-delegation-aux.rs

tests/ui/delegation/recursive_delegation_pass.rs

tests/ui/delegation/recursive_delegation_errors.rs

compiler/rustc_resolve/src/late.rs

compiler/rustc_middle/src/ty/mod.rs

compiler/rustc_ast_lowering/src/delegation.rs

aerooneqq · 2025-12-16T08:01:35Z

@rustbot ready

compiler/rustc_middle/src/ty/mod.rs

compiler/rustc_ast_lowering/src/delegation.rs

aerooneqq · 2025-12-17T07:48:20Z

@rustbot ready

compiler/rustc_ast_lowering/src/delegation.rs

petrochenkov · 2025-12-17T20:42:51Z

Mostly ready.
Could you also squash commits after addressing the comments?
@rustbot author

rustbot · 2025-12-17T20:42:55Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

aerooneqq · 2025-12-18T07:47:02Z

@rustbot ready

petrochenkov · 2025-12-18T07:54:29Z

Thanks!
@bors r+

bors · 2025-12-18T07:54:32Z

📌 Commit ae5e0d5 has been approved by petrochenkov

It is now in the queue for this repository.

Support recursive delegation This PR adds support for recursive delegations and is a part of the delegation feature #118212. r? `@petrochenkov`

bors · 2025-12-18T08:11:59Z

⌛ Testing commit ae5e0d5 with merge 31ce8ca...

bors · 2025-12-18T08:18:17Z

💔 Test failed - checks-actions

JonathanBrouwer · 2025-12-18T08:24:15Z

@bors retry

Support recursive delegation This PR adds support for recursive delegations and is a part of the delegation feature #118212. r? `@petrochenkov`

bors · 2025-12-18T08:34:19Z

⌛ Testing commit ae5e0d5 with merge 477664c...

rust-log-analyzer · 2025-12-18T08:40:29Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2025-12-18T08:42:46Z

💔 Test failed - checks-actions

rust-log-analyzer · 2025-12-18T09:48:31Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)


#1 [internal] booting buildkit
#1 pulling image ghcr.io/rust-lang/buildkit:buildx-stable-1
#1 pulling image ghcr.io/rust-lang/buildkit:buildx-stable-1 15.2s done
#1 ERROR: Error response from daemon: Head "https://ghcr.io/v2/rust-lang/buildkit/manifests/buildx-stable-1": Get "https://ghcr.io/token?account=rust-lang&scope=repository%3Arust-lang%2Fbuildkit%3Apull&service=ghcr.io": context deadline exceeded
------
 > [internal] booting buildkit:
------
ERROR: failed to build: Error response from daemon: Head "https://ghcr.io/v2/rust-lang/buildkit/manifests/buildx-stable-1": Get "https://ghcr.io/token?account=rust-lang&scope=repository%3Arust-lang%2Fbuildkit%3Apull&service=ghcr.io": context deadline exceeded
Command failed. Attempt 2/5:
#0 building with "exciting_visvesvaraya" instance using docker-container driver

#1 [internal] booting buildkit
#1 pulling image ghcr.io/rust-lang/buildkit:buildx-stable-1
---
7a29b2102ee3: Retrying in 3 seconds
7a29b2102ee3: Retrying in 2 seconds
7a29b2102ee3: Retrying in 1 second
7a29b2102ee3: Pushed
Head "https://ghcr.io/v2/rust-lang/rust-ci/blobs/sha256:552a3002a8207eb5391e45a34890c8e8a0c08da94d56acedad255bdf16db1be3": dial tcp 140.82.116.33:443: i/o timeout
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"
echo "disk usage:"
df -h
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

JonathanBrouwer · 2025-12-18T09:54:48Z

@bors retry (Spurious)

…r=petrochenkov Support recursive delegation This PR adds support for recursive delegations and is a part of the delegation feature rust-lang#118212. r? `@petrochenkov`

…uwer Rollup of 11 pull requests Successful merges: - #145933 (Expand `str_as_str` to more types) - #148849 (Set -Cpanic=abort in windows-msvc stack protector tests) - #149925 (`cfg_select!`: parse unused branches) - #150022 (Generate macro expansion for rust compiler crates docs) - #150024 (Support recursive delegation) - #150048 (std_detect: AArch64 Darwin: expose SME F16F16 and B16B16 features) - #150083 (tests/run-make-cargo/same-crate-name-and-macro-name: New regression test) - #150102 (Fixed ICE for EII with multiple defaults due to duplicate definition in nameres) - #150124 (unstable.rs: fix typos in comments (implementatble -> implementable)) - #150125 (Port `#[rustc_lint_opt_deny_field_access]` to attribute parser) - #150126 (Subtree sync for rustc_codegen_cranelift) Failed merges: - #150127 (Port `#[rustc_lint_untracked_query_information]` and `#[rustc_lint_diagnostics]` to using attribute parsers) r? `@ghost` `@rustbot` modify labels: rollup

…uwer Rollup of 12 pull requests Successful merges: - #145933 (Expand `str_as_str` to more types) - #148849 (Set -Cpanic=abort in windows-msvc stack protector tests) - #149925 (`cfg_select!`: parse unused branches) - #149952 (Suggest struct pattern when destructuring Range with .. syntax) - #150022 (Generate macro expansion for rust compiler crates docs) - #150024 (Support recursive delegation) - #150048 (std_detect: AArch64 Darwin: expose SME F16F16 and B16B16 features) - #150083 (tests/run-make-cargo/same-crate-name-and-macro-name: New regression test) - #150102 (Fixed ICE for EII with multiple defaults due to duplicate definition in nameres) - #150124 (unstable.rs: fix typos in comments (implementatble -> implementable)) - #150125 (Port `#[rustc_lint_opt_deny_field_access]` to attribute parser) - #150126 (Subtree sync for rustc_codegen_cranelift) Failed merges: - #150127 (Port `#[rustc_lint_untracked_query_information]` and `#[rustc_lint_diagnostics]` to using attribute parsers) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #150024 - aerooneqq:recursive-delegation-2, r=petrochenkov Support recursive delegation This PR adds support for recursive delegations and is a part of the delegation feature #118212. r? ``@petrochenkov``

rustbot assigned petrochenkov Dec 15, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 15, 2025

petrochenkov added the F-fn_delegation `#![feature(fn_delegation)]` label Dec 15, 2025

petrochenkov reviewed Dec 15, 2025

View reviewed changes

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 15, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 16, 2025

petrochenkov reviewed Dec 16, 2025

View reviewed changes

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 17, 2025

petrochenkov reviewed Dec 17, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2025

Support recursive delegation

ae5e0d5

aerooneqq force-pushed the recursive-delegation-2 branch from 27fef14 to ae5e0d5 Compare December 18, 2025 07:45

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 18, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2025

petrochenkov mentioned this pull request Dec 18, 2025

Tracking Issue for function delegation (fn_delegation, RFC 3530) #118212

Open

29 tasks

bors added a commit that referenced this pull request Dec 18, 2025

Auto merge of #150024 - aerooneqq:recursive-delegation-2, r=petrochenkov

31ce8ca

Support recursive delegation This PR adds support for recursive delegations and is a part of the delegation feature #118212. r? `@petrochenkov`

bors mentioned this pull request Dec 18, 2025

Expand str_as_str to more types #145933

Merged

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 18, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2025

bors added a commit that referenced this pull request Dec 18, 2025

Auto merge of #150024 - aerooneqq:recursive-delegation-2, r=petrochenkov

477664c

Support recursive delegation This PR adds support for recursive delegations and is a part of the delegation feature #118212. r? `@petrochenkov`

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 18, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2025

JonathanBrouwer mentioned this pull request Dec 18, 2025

Rollup of 11 pull requests #150132

Closed

JonathanBrouwer mentioned this pull request Dec 18, 2025

Rollup of 12 pull requests #150135

Merged

bors merged commit 1e496bc into rust-lang:main Dec 18, 2025
11 of 12 checks passed

rustbot added this to the 1.94.0 milestone Dec 18, 2025

matthiaskrgr mentioned this pull request Dec 19, 2025

ICE: delegation: unreachable #150152

Open

Uh oh!

Support recursive delegation #150024

Support recursive delegation #150024

Conversation

aerooneqq commented Dec 15, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aerooneqq commented Dec 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aerooneqq commented Dec 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

petrochenkov commented Dec 17, 2025

Uh oh!

rustbot commented Dec 17, 2025

Uh oh!

aerooneqq commented Dec 18, 2025

Uh oh!

petrochenkov commented Dec 18, 2025

Uh oh!

bors commented Dec 18, 2025

Uh oh!

bors commented Dec 18, 2025

Uh oh!

bors commented Dec 18, 2025

Uh oh!

JonathanBrouwer commented Dec 18, 2025

Uh oh!

bors commented Dec 18, 2025

Uh oh!

rust-log-analyzer commented Dec 18, 2025

Uh oh!

bors commented Dec 18, 2025

Uh oh!

rust-log-analyzer commented Dec 18, 2025

Uh oh!

JonathanBrouwer commented Dec 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

aerooneqq commented Dec 15, 2025 •

edited by rustbot

Loading