Document that Result.unwrap prints the Err's value #15632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Could you tweak the documentation to say that instead of printing the task fails with |
Contributor
Author
|
Sure. Maybe model the precise message after
would that work? Should I squash the new commit atop the old one? |
Member
|
That sounds good to me! And yes, I'm a fan of squashing :) |
It is implied by the Show bound, but that implication can be missed.
Contributor
Author
|
Here's a version with error messages matching that of |
Contributor
|
|
bors
added a commit
that referenced
this pull request
Jul 14, 2014
I saw that it was bounded by `Show` but the implication is no guarantee (and had only 0.10 to test, where this behavior has been added to 0.11)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 13, 2023
scip: Use load_workspace_at. This honors the build script config, and is also simpler.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 16, 2025
- only lint on definitions of offending mutexes, not all their uses (fixes rust-lang/rust-clippy#13378) - give more orderly help messages - stop linting on `Mutex<*const T>` (see the corresponding commit for context) - offer (partial) suggestions The last change might be deemed a bit too much for the feature freeze, but it can be easily extracted out into a separate PR. changelog: [`mutex_atomic`]: only lint the definitions, not uses changelog: [`mutex_atomic`]: better help messages, and suggestions changelog: [`mutex_atomic`]: don't lint `Mutex<*const T>` changelog: [`mutex_integer`]: only lint the definitions, not uses changelog: [`mutex_integer`]: better help messages, and suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw that it was bounded by
Showbut the implication is no guarantee (and had only 0.10 to test, where this behavior has been added to 0.11)