repair macro docs #15751
Closed
repair macro docs #15751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Appearing at the toplevel isn't as nice since |
Contributor
Won't that still break the |
Contributor
|
r+ retracted. @jbclements travis failed with a legit fold_mac error in stdtest |
Member
|
It seems like the easy solution is to just tack on |
Contributor
Author
|
ha! funny! hoist by my own petard. These are the checks that I added to make sure that no macros are left in the crate after expansion. But this patch does stow those macros in the crate. I'm just going to tweak fold_crate, a bit. |
bors
added a commit
that referenced
this pull request
Jul 19, 2014
In f1ad425, I changed the handling of macros, to prevent macro invocations from occurring in fully expanded source. Instead, I added a side table. It contained only the spans of the macros, because this was the only information required in order to make macro export work. However, librustdoc was also affected by this change, since it extracts macro information in a similar way. As a result of the earlier change, exported macros were no longer documented. In order to repair this, I've adjusted the side table to contain whole items, rather than just the spans. Note that the resulting macro documentation now appears at the top level of the crate.
In f1ad425, I changed the handling of macros, to prevent macro invocations from occurring in fully expanded source. Instead, I added a side table. It contained only the spans of the macros, because this was the only information required in order to make macro export work. However, librustdoc was also affected by this change, since it extracts macro information in a similar way. As a result of the earlier change, exported macros were no longer documented. In order to repair this, I've adjusted the side table to contain whole items, rather than just the spans.
ghost
mentioned this pull request
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 16, 2025
Some methods lints were handled in the `methods` module outside the `check_methods()` function. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In f1ad425, I changed the handling
of macros, to prevent macro invocations from occurring in fully expanded
source. Instead, I added a side table. It contained only the
spans of the macros, because this was the only information required
in order to make macro export work.
However, librustdoc was also affected by this change, since it
extracts macro information in a similar way. As a result of the earlier
change, exported macros were no longer documented.
In order to repair this, I've adjusted the side table to contain whole
items, rather than just the spans.
Note that the resulting macro documentation now appears at the
top level of the crate.
Fixes #15645