Cleanup some fixed Windows issues #16450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
You may want to back out the addition of |
Contributor
|
😍 @klutzy! |
Contributor
Author
|
Retracted #13846. It seems blocked by other issue. |
Member
|
(needs a rebase) |
LLVM assertion error has been fixed recently: http://llvm.org/bugs/show_bug.cgi?id=18993 Fixes rust-lang#13793
Contributor
Author
|
rebased! |
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 20, 2024
…ykril internal: Prepare parser interface for editions
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 20, 2024
…icola minor: Fix `rustc_skip_array_during_method_dispatch` edition check CC rust-lang#16450
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 20, 2024
…ykril internal: Prepare parser interface for editions
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 20, 2024
…icola minor: Fix `rustc_skip_array_during_method_dispatch` edition check CC rust-lang#16450
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit enables regex test on Windows. It was not working at some point (#13725), but it works now.
Second commit removes various FIXMEs regarding #13793, since upstream bug has been fixed.