Skip to content

Conversation

@nrc
Copy link
Member

@nrc nrc commented Feb 5, 2015

Closes #20022

r? @nikomatsakis

@jroesch
Copy link
Contributor

jroesch commented Feb 5, 2015

The patch looks good, I think it is wise to prefer the hack for the time being.

@nikomatsakis
Copy link
Contributor

This looks good but don't we want some tests of some kind?

@nikomatsakis
Copy link
Contributor

(PS sorry it took me so long to review, I didn't notice this for a while)

@nrc
Copy link
Member Author

nrc commented Feb 8, 2015

ah, crap, I forgot to git add the test...

@nrc
Copy link
Member Author

nrc commented Feb 9, 2015

rebased and added tests

@nikomatsakis
Copy link
Contributor

Seems reasonable. I'd sort of like a test that shows that the correct requirements are being put onto the caller (e.g. a compile-fail test where the requirement is for<'a> &'a T : Foo but the caller only knows that &'x T : Foo holds for some particular 'x)

@nrc
Copy link
Member Author

nrc commented Feb 9, 2015

@nikomatsakis test added

@nikomatsakis
Copy link
Contributor

@bors r+ c50a8f930245aa2a5a52e230c68a298c84f5a8a1

@bors
Copy link
Collaborator

bors commented Feb 9, 2015

⌛ Testing commit c50a8f9 with merge 5f2ab7f...

@bors
Copy link
Collaborator

bors commented Feb 10, 2015

💔 Test failed - auto-mac-32-opt

@nrc
Copy link
Member Author

nrc commented Feb 10, 2015

@bors r=nmatsakis f9c577e

bors added a commit that referenced this pull request Feb 10, 2015
@bors
Copy link
Collaborator

bors commented Feb 10, 2015

⌛ Testing commit f9c577e with merge de8bc44...

@bors
Copy link
Collaborator

bors commented Feb 10, 2015

@bors bors merged commit f9c577e into rust-lang:master Feb 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Permit higher-ranked qualifiers to enclose the self type

4 participants