Generate relative paths for -C rpath again #23283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
This was referenced Mar 11, 2015
Merged
Member
|
cc @aturon |
Collaborator
|
☔ The latest upstream changes (presumably #23229) made this pull request unmergeable. Please resolve the merge conflicts. |
The new `relative_from` method no longer supports the case on unix where both paths are absolute, which `-C rpath` depended on. This version fixes the problem by copying the old path_relative_from function into the rpath module. Fixes rust-lang#23140
Member
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 23, 2015
Fix regression in -C rpath that causes failures with symlinks The new `relative_from` method no longer supports the case on unix where both paths are absolute, which `-C rpath` depended on. This version fixes the problem by copying the old path_relative_from function into the rpath module. Fixes rust-lang#23140 After experimenting with the new `relative_from` function on `Path` I'm not sure what it's use case is. It no longer even figures out that the relative path from `/foo/bar` to `/foo/baz/qux` is `../baz/qux`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression in -C rpath that causes failures with symlinks
The new
relative_frommethod no longer supports the case on unixwhere both paths are absolute, which
-C rpathdepended on. Thisversion fixes the problem by copying the old path_relative_from
function into the rpath module.
Fixes #23140
After experimenting with the new
relative_fromfunction onPathI'm not sure what it's use case is. It no longer even figures out that the relative path from/foo/barto/foo/baz/quxis../baz/qux.