Skip to content

Remove stdlib stuff from the Reference #23285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Mar 28, 2015
Merged

Remove stdlib stuff from the Reference #23285

bors merged 1 commit into from
Mar 28, 2015

Conversation

@steveklabnik
Copy link
Contributor

@steveklabnik steveklabnik commented Mar 11, 2015

Fixes #11794

I mostly removed superflous examples which use the standard library.

I have one more quesiton here though: threads. They're mostly a library thing, at this point, right?

@rust-highfive
Copy link
Contributor

rust-highfive commented Mar 11, 2015

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik
Copy link
Contributor Author

steveklabnik commented Mar 16, 2015

r? @nikomatsakis

@steveklabnik
Copy link
Contributor Author

steveklabnik commented Mar 16, 2015

@nikomatsakis I re-added in Copy, tweaked that wording, and removed references to threads.

nikomatsakis
nikomatsakis reviewed Mar 16, 2015
View reviewed changes
src/doc/reference.md Outdated
Copy link
Contributor

@nikomatsakis nikomatsakis Mar 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "whose"

Copy link
Contributor Author

@steveklabnik steveklabnik Mar 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

nikomatsakis
nikomatsakis reviewed Mar 16, 2015
View reviewed changes
src/doc/reference.md
Copy link
Contributor

@nikomatsakis nikomatsakis Mar 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably say "destructors are executed" but anyway

Copy link
Contributor Author

@steveklabnik steveklabnik Mar 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we can go over this with the general reference cleanup post-beta

@steveklabnik
Copy link
Contributor Author

steveklabnik commented Mar 19, 2015

@nikomatsakis ping!

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Mar 27, 2015

@bors r+ ac67729

@steveklabnik
Copy link
Contributor Author

steveklabnik commented Mar 27, 2015

@bors: rollup

@steveklabnik
Copy link
Contributor Author

steveklabnik commented Mar 27, 2015

@bors: r=nikomatsakis rollup

@bors
Copy link
Collaborator

bors commented Mar 27, 2015

📌 Commit ac67729 has been approved by nikomatsakis

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 27, 2015
@alexcrichton
rollup merge of rust-lang#23285: steveklabnik/gh11794
3f1d57f 
Fixes rust-lang#11794

I mostly removed superflous examples which use the standard library.

I have one more quesiton here though: threads. They're mostly a library thing, at this point, right?
@bors bors merged commit ac67729 into rust-lang:master Mar 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakis nikomatsakis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

remove standard library information from the Rust manual

5 participants

@steveklabnik @rust-highfive @nikomatsakis @bors @pcwalton