Skip to content

Conversation

@astraw
Copy link
Contributor

@astraw astraw commented Apr 27, 2015

If you have 0 references (&T) to a resource, presumably, you could have a mutable reference (&mut T). So this only start to make sense at having 1 reference to a resource.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@steveklabnik
Copy link
Contributor

Yes, I agree with @pnkfelix here. @astraw , would you mind updating and squashing the PR? r=me after

If you have 0 references (`&T`) to a resource, presumably, you could
have a mutable reference (`&mut T`). So this only start to make sense
at having 1 reference to a resource.
@astraw
Copy link
Contributor Author

astraw commented May 8, 2015

@steveklabnik updated and squashed.

@steveklabnik
Copy link
Contributor

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented May 8, 2015

📌 Commit 391d148 has been approved by steveklabnik

@steveklabnik
Copy link
Contributor

Thank you!

Manishearth added a commit to Manishearth/rust that referenced this pull request May 8, 2015
If you have 0 references (`&T`) to a resource, presumably, you could have a mutable reference (`&mut T`). So this only start to make sense at having 1 reference to a resource.
Manishearth added a commit to Manishearth/rust that referenced this pull request May 8, 2015
If you have 0 references (`&T`) to a resource, presumably, you could have a mutable reference (`&mut T`). So this only start to make sense at having 1 reference to a resource.
bors added a commit that referenced this pull request May 8, 2015
@bors bors merged commit 391d148 into rust-lang:master May 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants