Use ast attributes every where (remove HIR attributes). #28399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Member
|
(or anyone else in @rust-lang/compiler) |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 9596009 has been approved by |
Collaborator
|
☔ The latest upstream changes (presumably #28274) made this pull request unmergeable. Please resolve the merge conflicts. |
Collaborator
|
☔ The latest upstream changes (presumably #28413) made this pull request unmergeable. Please resolve the merge conflicts. |
This could be a [breaking-change] if your lint or syntax extension (is that even possible?) uses HIR attributes or literals.
Member
Author
|
@bors: r=nikomatsakis |
Collaborator
|
📌 Commit e9f1b06 has been approved by |
bors
added a commit
that referenced
this pull request
Sep 16, 2015
This could be a [breaking-change] if your lint or syntax extension (is that even possible?) uses HIR attributes or literals.
Collaborator
Collaborator
This was referenced Sep 16, 2015
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be a [breaking-change] if your lint or syntax extension (is that even possible?) uses HIR attributes or literals.