Skip to content

Fix some typos in TRPL #29207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexcrichton merged 2 commits into from
Oct 23, 2015
Merged

Fix some typos in TRPL #29207

alexcrichton merged 2 commits into from
Oct 23, 2015

Conversation

@ykomatsu
Copy link
Contributor

@ykomatsu ykomatsu commented Oct 21, 2015

No description provided.

@rust-highfive
Copy link
Contributor

rust-highfive commented Oct 21, 2015

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

alexcrichton
alexcrichton reviewed Oct 21, 2015
View reviewed changes
src/doc/trpl/error-handling.md Outdated
Copy link
Member

@alexcrichton alexcrichton Oct 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may actually want to be "we've" ?

Copy link
Contributor

@steveklabnik steveklabnik Oct 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct!

Copy link
Contributor Author

@ykomatsu ykomatsu Oct 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @alexcrichton and @steveklabnik.

I corrected this.

@steveklabnik
Copy link
Contributor

steveklabnik commented Oct 22, 2015

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 22, 2015

📌 Commit f609d17 has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Oct 22, 2015
@steveklabnik
Rollup merge of rust-lang#29207 - ykomatsu:trpl, r=steveklabnik
2c540c3
@steveklabnik steveklabnik mentioned this pull request Oct 22, 2015
Closed
@steveklabnik steveklabnik mentioned this pull request Oct 22, 2015
Merged
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Oct 22, 2015
@steveklabnik
Rollup merge of rust-lang#29207 - ykomatsu:trpl, r=steveklabnik
58fed89
bors added a commit that referenced this pull request Oct 22, 2015
@bors
Auto merge of #29236 - steveklabnik:rollup, r=steveklabnik
7beebbe 
- Successful merges: #29170, #29180, #29193, #29207, #29213, #29224, #29230
- Failed merges:
@alexcrichton alexcrichton merged commit f609d17 into rust-lang:master Oct 23, 2015
@ykomatsu ykomatsu deleted the trpl branch October 23, 2015 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steveklabnik steveklabnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ykomatsu @rust-highfive @steveklabnik @bors @alexcrichton