Skip to content

Add missing urls for Box doc #36576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Sep 30, 2016
Merged

Add missing urls for Box doc #36576

bors merged 1 commit into from
Sep 30, 2016

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Sep 19, 2016

GuillaumeGomez
GuillaumeGomez commented Sep 19, 2016
View reviewed changes
src/liballoc/boxed.rs Outdated
Copy link
Member Author

@GuillaumeGomez GuillaumeGomez Sep 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this note really useful? We have an example just below after all...

ollie27
ollie27 reviewed Sep 19, 2016
View reviewed changes
src/liballoc/boxed.rs Outdated
Copy link
Contributor

@ollie27 ollie27 Sep 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be struct.Box.html#method.from_raw.

Copy link
Member Author

@GuillaumeGomez GuillaumeGomez Sep 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Sep 24, 2016

@steveklabnik: ping

@steveklabnik
Copy link
Contributor

steveklabnik commented Sep 30, 2016

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 30, 2016

📌 Commit dfa0940 has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Sep 30, 2016
@steveklabnik
Rollup merge of rust-lang#36576 - GuillaumeGomez:box_urls, r=stevekla…
71a4bde 
…bnik

Add missing urls for Box doc

r? @steveklabnik
@steveklabnik steveklabnik mentioned this pull request Sep 30, 2016
Merged
bors added a commit that referenced this pull request Sep 30, 2016
@bors
Auto merge of #36864 - steveklabnik:rollup, r=steveklabnik
50932b5 
Rollup of 13 pull requests

- Successful merges: #36529, #36535, #36576, #36623, #36711, #36750, #36810, #36829, #36833, #36841, #36842, #36851, #36860
- Failed merges:
@bors bors merged commit dfa0940 into rust-lang:master Sep 30, 2016
@GuillaumeGomez GuillaumeGomez deleted the box_urls branch October 1, 2016 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ollie27 ollie27 ollie27 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@steveklabnik steveklabnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez @steveklabnik @bors @ollie27