Reduce str transmutes, add mut versions of methods. #41096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfackler
reviewed
Apr 5, 2017
src/libcollections/str.rs
Outdated
Contributor
Author
There was a problem hiding this comment.
For some reason I thought I annotated this as unsafe but I didn't.
clarfonthey
force-pushed
the
as_bytes_mut
branch
from
5c07471 to
68a18bf
Compare
Member
|
These seem like reasonable additions to me! (clear mirrors of the slice equivalents) |
alexcrichton
added
the
T-libs-api
Member
|
Looks like travis also has failures? |
Contributor
Author
|
Travis failures are due to a requirement for docs of the new features; I will fix those in a bit. |
clarfonthey
force-pushed
the
as_bytes_mut
branch
from
68a18bf to
3af3bb3
Compare
clarfonthey
force-pushed
the
as_bytes_mut
branch
2 times, most recently
from
de78499 to
7d00622
Compare
Contributor
Author
|
Also I just added a |
Member
|
Looks like the build may still be failing? |
clarfonthey
force-pushed
the
as_bytes_mut
branch
4 times, most recently
from
d20e65e to
aded772
Compare
clarfonthey
force-pushed
the
as_bytes_mut
branch
from
aded772 to
a2b28be
Compare
Contributor
Author
|
Seems to be passing now! |
Member
|
@bors: r+ |
Collaborator
|
📌 Commit a2b28be has been approved by |
Collaborator
|
⌛ Testing commit a2b28be with merge dc93ce2... |
Collaborator
|
💔 Test failed - status-appveyor |
Contributor
Collaborator
|
⌛ Testing commit a2b28be with merge 478d3b2... |
Collaborator
|
💔 Test failed - status-appveyor |
Contributor
Collaborator
|
⌛ Testing commit a2b28be with merge 2137a14... |
Collaborator
|
💔 Test failed - status-appveyor |
Contributor
Collaborator
bors
added a commit
that referenced
this pull request
Apr 11, 2017
Reduce str transmutes, add mut versions of methods. When I was working on the various parts involved in #40380 one of the comments I got was the excess of transmutes necessary to make the changes work. This is part of a set of multiple changes I'd like to offer to fix this problem. I think that having these methods is reasonable because they're already possible via transmutes, and it makes the code that uses them safer. I can also add `pub(crate)` to these methods for now if the libs team would rather not expose them to the public without an RFC.
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
bors
added a commit
that referenced
this pull request
Apr 26, 2017
More methods for str boxes. (reduce Box<[u8]> ↔ Box<str> transmutes) This is a follow-up to #41096 that adds safer methods for converting between `Box<str>` and `Box<[u8]>`. They're gated under a different feature from the `&mut str` methods because they may be too niche to include in public APIs, although having them internally helps reduce the number of transmutes the standard library uses. What's added: * `From<Box<str>> for Box<[u8]>` * `<Box<str>>::into_boxed_bytes` (just calls `Into::into`) * `alloc::str` (new module) * `from_boxed_utf8` and `from_boxed_utf8_unchecked`, defined in `alloc:str`, exported in `collections::str` * exports `from_utf8_mut` in `collections::str` (missed from previous PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was working on the various parts involved in #40380 one of the comments I got was the excess of transmutes necessary to make the changes work. This is part of a set of multiple changes I'd like to offer to fix this problem.
I think that having these methods is reasonable because they're already possible via transmutes, and it makes the code that uses them safer. I can also add
pub(crate)to these methods for now if the libs team would rather not expose them to the public without an RFC.