Skip to content

[beta] Backports #47327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 6 commits into from
Jan 11, 2018
Merged

[beta] Backports #47327

bors merged 6 commits into from
Jan 11, 2018

Conversation

@MaloJaffre
Copy link
Contributor

@MaloJaffre MaloJaffre commented Jan 10, 2018

@rust-highfive
Copy link
Contributor

rust-highfive commented Jan 10, 2018

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

rust-highfive commented Jan 10, 2018

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2018
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Jan 10, 2018

Can you also bump the beta version number? That way we can release a new beta with these backports. Thanks!

@MaloJaffre
Copy link
Contributor Author

MaloJaffre commented Jan 10, 2018

@Mark-Simulacrum Done!

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Jan 10, 2018

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 10, 2018

📌 Commit 6ff413e has been approved by Mark-Simulacrum

@kennytm
Copy link
Member

kennytm commented Jan 10, 2018

@bors p=1

@bors
Copy link
Collaborator

bors commented Jan 10, 2018

⌛ Testing commit 6ff413e with merge a19122c...

bors added a commit that referenced this pull request Jan 10, 2018
@bors
Auto merge of #47327 - MaloJaffre:beta-backport, r=Mark-Simulacrum
a19122c 
[beta] Backports

Cherry-picked (cleanly) into beta:
- #46916
- #47161
- #47208
- #47269
@petrochenkov petrochenkov added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2018
@bors
Copy link
Collaborator

bors commented Jan 11, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing a19122c to beta...

@bors bors merged commit 6ff413e into rust-lang:beta Jan 11, 2018
@alexcrichton
Copy link
Member

alexcrichton commented Jan 11, 2018

Thanks for the backport here @MaloJaffre!

@MaloJaffre MaloJaffre deleted the beta-backport branch January 11, 2018 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@MaloJaffre @rust-highfive @Mark-Simulacrum @bors @kennytm @alexcrichton @petrochenkov @michaelwoerister @Manishearth