Skip to content

Clean up err codes #67837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 3 commits into from
Jan 4, 2020
Merged

Clean up err codes #67837

bors merged 3 commits into from
Jan 4, 2020

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Jan 3, 2020

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 3, 2020
Dylan-DPC-zz
Dylan-DPC-zz suggested changes Jan 3, 2020
View reviewed changes
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jan 3, 2020

Updated! Thanks for the review @Dylan-DPC ! :)

@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 4, 2020
Merged
@Dylan-DPC-zz
Copy link

Dylan-DPC-zz commented Jan 4, 2020

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 4, 2020

📌 Commit 062cd78 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2020
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 4, 2020
@GuillaumeGomez
Rollup merge of rust-lang#67837 - GuillaumeGomez:clean-up-err-codes, …
5c73be1 
…r=Dylan-DPC

Clean up err codes

r? @Dylan-DPC
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 4, 2020
Merged
bors added a commit that referenced this pull request Jan 4, 2020
@bors
Auto merge of #67866 - GuillaumeGomez:rollup-32vsg5b, r=GuillaumeGomez
cd8377d 
Rollup of 4 pull requests

Successful merges:

 - #67822 (Revert `const_err` lint checking of casts)
 - #67823 (improve some `Drop`-related error messages)
 - #67837 (Clean up err codes)
 - #67848 (Remove unused `#[link_name = "m"]` attributes)

Failed merges:

r? @ghost
@bors bors merged commit 062cd78 into rust-lang:master Jan 4, 2020
@GuillaumeGomez GuillaumeGomez deleted the clean-up-err-codes branch January 5, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Dylan-DPC-zz Dylan-DPC-zz Dylan-DPC-zz requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Dylan-DPC-zz Dylan-DPC-zz

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@GuillaumeGomez @Dylan-DPC-zz @bors @rust-highfive @Dylan-DPC