Skip to content

Break out early on empty span when generate_fn_span #72261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
May 17, 2020
Merged

Break out early on empty span when generate_fn_span #72261

bors merged 1 commit into from
May 17, 2020
+17 −8

Conversation

@csmoe
Copy link
Contributor

@csmoe csmoe commented May 16, 2020

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 16, 2020
@estebank
Copy link
Contributor

estebank commented May 16, 2020

@bors r+ r? @estebank

I'm ok with this change, but we need to audit uses of generate_fn_name_span and see if we instead can use the item's ident's span instead.

@bors
Copy link
Collaborator

bors commented May 16, 2020

📌 Commit 2e1c2a6 has been approved by estebank

@rust-highfive rust-highfive assigned estebank and unassigned oli-obk May 16, 2020
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2020
@estebank
Copy link
Contributor

estebank commented May 16, 2020

@csmoe If you see this before its merged, can you add a regression test?

@RalfJung RalfJung mentioned this pull request May 17, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 17, 2020
@bors
Auto merge of rust-lang#72295 - RalfJung:rollup-icmhbs7, r=RalfJung
d79f1bd 
Rollup of 3 pull requests

Successful merges:

 - rust-lang#72259 (Disallow forbidden usage of non-ascii identifiers.)
 - rust-lang#72261 (Break out early on empty span when generate_fn_span)
 - rust-lang#72291 (bootstrap: fix typo)

Failed merges:

r? @ghost
@bors bors merged commit 65833dc into rust-lang:master May 17, 2020
@csmoe
Copy link
Contributor Author

csmoe commented May 20, 2020

@estebank really sorry, my github notification is broken 😢, I'll file a test case soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@estebank estebank

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

thread 'rustc' panicked at 'no label after fn', src/libcore/option.rs:1188:5

5 participants

@csmoe @estebank @bors @oli-obk @rust-highfive