clean up the vector module #7263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Is 'for foo.iter().enumerate().advance |(i, ee)|' going to be the blessed way to iterate with an index going forward? Or is this just a stopgap? It would be really disappointing if this were the final form, imo. |
Contributor
Author
|
@jfager: for loops are going to be switched to external iterators, so the An The sooner these changes are done, the sooner it will look good without being crippled like our current iteration protocol. |
An Iterator implementation can be made for &const [T] if it turns out to be necessary for some use case.
replaced by the `enumerate` method from std::iterator
The removed test for issue #2611 is well covered by the `std::iterator` module itself. This adds the `count` method to `IteratorUtil` to replace `EqIter`.
bors
added a commit
that referenced
this pull request
Jun 21, 2013
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 3, 2021
Fix `redundant_closure` for `vec![]` macro in a closure with arguments fixes: rust-lang#7224 changelog: Fix `redundant_closure` for `vec![]` macro in a closure with arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.