canonicalize consts before calling try_unify_abstract_consts query #88166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
lcnr
reviewed
Aug 19, 2021
lcnr
reviewed
Aug 19, 2021
BoxyUwU
force-pushed
the
const-equate-canon
branch
from
fc4d559 to
c2b61fb
Compare
lcnr
added
F-generic_const_exprs
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit c2b61fb has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88022
Fixes #86953
Fixes #77708
Fixes #82034
Fixes #85031
these ICEs were all caused by calling the
try_unify_abstract_constsquery with inference vars in substsr? @lcnr