Update Clippy #98173
Merged
Update Clippy #98173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t and into_iterator
The fixed issue in this commit can be tested without depending on clap/clap_derive. This updates the test case to do so.
fix(manual_find_map and manual_filter_map): check clone method close rust-lang#8920 Added conditional branching when the clone method is used. Thank you in advance. --- changelog: check `clone()` and other variant preserving methods in [`manual_find_map`] and [`manual_filter_map`]
Remove duplication in creating suggestions by first mapping assignments to spans and then suggestions.
Simplify the creation of suggestions by using `flat_map` instead of `chain`. Note that the order of the suggestions is not important.
Remove the unneeded wrapping and unwrapping in suggestion creation. Collecting to Option<Vec<_>> only returns None if one of the elements is None and that is never the case here.
…r=llogiq improve [`for_loops_over_fallibles`] to detect the usage of iter, iter_mut and into_iterator fix rust-lang#6762 detects code like ```rust for _ in option.iter() { //.. } ``` changelog: Improve [`for_loops_over_fallibles`] to detect `for _ in option.iter() {}` or using `iter_mut()` or `into_iterator()`.
Co-authored-by: Alex <[email protected]>
Co-authored-by: Alex <[email protected]>
Co-authored-by: dswij <[email protected]>
Remove error-pattern comments The `clippy_lints` one [is unused](https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/.60error-pattern.60), the others in `ui-toml` also appear not to have an effect changelog: none
Warn about read into zero-length `Vec` Closes rust-lang#8886 - \[x] Followed [lint naming conventions][lint_naming] - \[x] Added passing UI tests (including committed `.stderr` file) - \[x] `cargo test` passes locally - \[x] Executed `cargo dev update_lints` - \[x] Added lint documentation - \[x] Run `cargo dev fmt` changelog: none
Make `ExprKind::Closure` a struct variant. Simple refactor since we both need it to introduce additional fields in `ExprKind::Closure`. r? ``@Aaron1011``
Fix false positive for `never_loop` struct expression fields Fixes rust-lang#9001. changelog: [`never_loop`]: Now checks for `continue` in struct expression
This is just to ensure that the book builds all time to not get in trouble when syncing with rust-lang/rust
Build mdbook in remark workflow r? `@xFrednet` Supersedes rust-lang#8959 changelog: none
Rustup r? `@ghost` changelog: none
Contributor
|
Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
rust-highfive
added
the
S-waiting-on-review
Member
|
@bors r+ p=1 rollup=never |
Collaborator
|
📌 Commit 37cdd7e has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (3bebee7): comparison url. Instruction count
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Manishearth