Drop script-servo-2 benchmark #740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This benchmark takes 31% of our CI time, despite considerable time spent trying to optimize it. However, we have not found that it is particularly notable when compared to our other large crate benchmarks. script-servo has also historically shown some amount of non-determinism in the CGU partioning which also makes it an annoying benchmark. Most people profiling locally just disable it because of how long it takes.
Contributor
|
It's a shame to lose this benchmark, but the cost/benefit ratio just isn't favourable. I almost always skip it when doing local runs. Also, the total duration of the perf suite is a real problem, because CI perf runs have been struggling to keep up with merges since the switch to GitHub Actions reduced the time per merge down to about 2 hours. Removing this benchmark is the simplest and most effective step for reducing the duration. r=me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This benchmark takes 31% of our CI time, despite considerable time spent trying
to optimize it. However, we have not found that it is particularly notable when
compared to our other large crate benchmarks.
script-servo has also historically shown some amount of non-determinism in the
CGU partioning which also makes it an annoying benchmark.
Most people profiling locally just disable it because of how long it takes.
r? @nnethercote