Fix: rustfmt should not remove inner attributes from inline const blocks #6173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytmimi
changed the title
ytmimi
changed the title
ytmimi
requested changes
May 24, 2024
Contributor
ytmimi
left a comment
ytmimi
left a comment
There was a problem hiding this comment.
Thanks for jumping in to work on this PR! With a few minor tweaks we should be good
Contributor
Author
|
Looks so pretty, I'm learned a lot. |
ytmimi
approved these changes
Jun 1, 2024
Contributor
ytmimi
left a comment
ytmimi
left a comment
There was a problem hiding this comment.
Thanks for making the requested changes!
Contributor
|
Diff check job also passed so we're good to go 👍🏼 |
ytmimi
added
release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6158
cargo test0 failedfirst time contributed on this project🥳