sigh, rename back to scala-collection-compat (and re-enable MiMa)

[SethTisue]

reverts #327

[SethTisue]

MiMa is failing, but only on 2.11?! I'm out of work time for today — I'll look into it tomorrow if nobody beats me to it.

[SethTisue]

The failure is due to the addition of toMapExtensionMethods in #341. lightbend-labs/mima#205 explains why it only fails on 2.11 (trait encoding difference).

I believe we can filter this out because the trait in question, PackageShared, is private[compat].

[SethTisue]

#362 has MiMa followups

[NthPortal]

@SethTisue I think that method should be moved directly into the package object (which duplicates it because there are separate files for 2.11 and 2.12, but there's not much to do about that). that's what we've been doing for other things

[SethTisue]

@NthPortal oops, I was going to look at that before release, but it slipped my mind. is it too late now, because bincompat?

[NthPortal]

I... don't know enough about bincompat to say what we should do

[SethTisue]

I... don't know enough about bincompat to say what we should do

Before I think too hard about that, I'd like to understand why you are suggesting the method should be moved directly into the package object.

which duplicates it because there are separate files for 2.11 and 2.12, but there's not much to do about that

I'm confused — isn't avoiding such duplication exactly what PackageShared is for?

[NthPortal]

the problem is, adding methods to PackageShared isn't binary compatible, I believe. see #292 and #288 (comment). this seems to be an issue for 2.11 bincompat

[SethTisue]

ah, thanks for surfacing that. @julienrf @lrytz was I wrong to add the MiMa exclusion here?

[julienrf]

was I wrong to add the MiMa exclusion here?

Indeed, the correct solution is to duplicate the implicit conversion into the 2.11 and 2.12 source trees, as April said in #356 (comment).

[NthPortal]

What is the correct thing to do now?

• move the method to the package objects, draft a new release ASAP, and make a note that the release was bad and shouldn't be used?
• leave it as is?
• have the method in both places?

[SethTisue]

What is the correct thing to do now?

Let's discuss on #367