Simplify/remove build.rs following the bump to 2021 edition #1062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved dispatch directly into the type system.
dtolnay
requested changes
Sep 11, 2023
Member
dtolnay
left a comment
dtolnay
left a comment
There was a problem hiding this comment.
Thanks! The retain and get_key_value and remove_entry changes look good.
I would prefer not to take the LimbConfig change. I think that code will be all right as is.
This reverts commit c754f03.
Co-authored-by: David Tolnay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since serde-json's MSRV is 1.56 (due to using a 2021 edition), most of the hidden features enabled in build.rs shouldn't ever get enabled during the build. They mostly indicated whether some of the BTreeMap methods were available.
The last one for limb_width can be implemented with a #[cfg] or two. it is a separate commit in case this change is not welcome - I see how it complicates code slightly.