Download libstd from alt builders. #17575
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the downloaded rustc and libstd may be incompatible.
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @mbrubeck (or someone else) soon. |
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
Member
|
Thank you, although I’ve already made the same changes in #17561. |
bors-servo
pushed a commit
that referenced
this pull request
Jun 30, 2017
Upgrade to rustc 1.20.0-nightly (69c65d296 2017-06-28) Fixes #17575. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17561) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this pull request
Jun 30, 2017
Upgrade to rustc 1.20.0-nightly (69c65d296 2017-06-28) Fixes #17575. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17561) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the downloaded rustc and libstd may be incompatible.
./mach build -ddoes not report any errors (haven't run, since I don't really want to wait for servo to compile, but should work)../mach test-tidydoes not report any errorsThis change is