Skip to content

Upgrade to rustc 1.22.0-nightly (c6884b12d 2017-09-30) #18693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors-servo merged 1 commit into from
Oct 1, 2017
Merged

Upgrade to rustc 1.22.0-nightly (c6884b12d 2017-09-30) #18693

bors-servo merged 1 commit into from
Oct 1, 2017

Conversation

@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Oct 1, 2017 •
edited
Loading

A new AddAssign impl in the standard library made inference ambiguous.

This change is Reviewable

@SimonSapin
Upgrade to rustc 1.22.0-nightly (c6884b12d 2017-09-30)
b6bfdc9 
A new `AddAssign` impl in the standard library made inference ambiguous.
@highfive
Copy link

highfive commented Oct 1, 2017

Heads up! This PR modifies the following files:

@highfive
Copy link

highfive commented Oct 1, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 1, 2017
@nox
Copy link
Contributor

nox commented Oct 1, 2017

Wait, that's not a Rust regression…?

@nox
Copy link
Contributor

nox commented Oct 1, 2017

What is the new AddAssign impl that causes this issue?

@SimonSapin
Copy link
Member Author

SimonSapin commented Oct 1, 2017 •
edited
Loading

impl<'a> AddAssign<&'a usize> for usize rust-lang/rust#41336 rust-lang/rust#44287

@SimonSapin SimonSapin mentioned this pull request Oct 1, 2017
Closed
@nox
Copy link
Contributor

nox commented Oct 1, 2017

@bors-servo r+

rust-lang/rust#41336 (comment)

@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2017

📌 Commit b6bfdc9 has been approved by nox

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 1, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2017

⌛ Testing commit b6bfdc9 with merge a2403c5...

bors-servo pushed a commit that referenced this pull request Oct 1, 2017
Auto merge of #18693 - servo:rustup, r=nox
a2403c5 
Upgrade to rustc 1.22.0-nightly (c6884b12d 2017-09-30)

A new `AddAssign` impl in the standard library made inference ambiguous.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18693)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 1, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: nox
Pushing a2403c5 to master...

@bors-servo bors-servo merged commit b6bfdc9 into master Oct 1, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 1, 2017
@nox nox deleted the rustup branch October 1, 2017 16:13
@michiel-de-muynck michiel-de-muynck mentioned this pull request Oct 2, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nox nox

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SimonSapin @highfive @nox @bors-servo