feat: OAuth extra params support and token status improvements #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 19963138983 --repo smart-mcp-proxy/mcpproxy-go
|
This commit implements OAuth extra parameters (RFC 8707) support and fixes
OAuth token status display in CLI commands.
Key changes:
- Add extra OAuth params (audience, resource, tenant) to authorization URLs
- Implement automatic OAuth state clearing when config changes
- Fix OAuth token lookup key mismatch (was using server name, now uses
server_name + URL hash to match PersistentTokenStore format)
- Add GetOAuthToken() and ClearOAuthState() methods to storage manager
- Add OAuthConfigChanged() comparison function for hot-reload detection
- Display OAuth token expiration time in `upstream list` and `auth status`
The token lookup fix resolves an issue where OAuth tokens were being stored
with composite keys (e.g., "sentry_abc123") but looked up with just the
server name ("sentry"), causing authenticated servers to show as pending.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
Previously, OAuth token lookup only ran for servers with explicit oauth config. Servers using OAuth autodiscovery (dynamic client registration) showed "-" in OAUTH TOKEN column and didn't appear in `auth status` output, even when they had valid tokens stored. Changes: - Move OAuth token lookup outside the `if serverStatus.Config.OAuth != nil` block so it runs for ALL servers with a URL - For autodiscovery servers (no explicit OAuth config), create minimal oauthConfig with `autodiscovery: true` flag when token is found - Update auth_cmd.go to detect autodiscovery flag and display "OAuth: Discovered via Dynamic Client Registration" message Now autorag-cf and other autodiscovery servers correctly show: - Token expiration time in upstream list (e.g., "49m") - Full auth status with "Authenticated & Connected" - Token expiration details 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Dumbris
force-pushed
the
006-oauth-extra-params
branch
from
7a6a7eb to
de85df8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
upstream list,auth status) to show accurate OAuth token expiration timesKey Changes
OAuth Extra Parameters Support
extra_paramsfield to OAuth config for custom parameters likeresource,audience,tenantOAuthTransportWrapperto inject extra params into authorization URLs and token requestsOAuth Token Status Display Fixes
oauth: nullin config)upstream listnow shows token expiration time for all OAuth serversauth statusnow correctly identifies and displays autodiscovery serversFiles Changed
internal/oauth/transport_wrapper.go- New OAuth transport wrapper for extra paramsinternal/oauth/masking.go- Parameter masking utilities for secure logginginternal/config/oauth_validation.go- Reserved parameter validationinternal/runtime/runtime.go- Fixed token lookup for autodiscovery serverscmd/mcpproxy/auth_cmd.go- Improved auth status displaycmd/mcpproxy/upstream_cmd.go- Token expiration displayTest plan
🤖 Generated with Claude Code