strftime deprecated in PHP 8.1

[mambax7]

Unknown: Function strftime() is deprecated in file /Smarty_Compiler.class.php line 395
Unknown: preg_match_all(): Passing null to parameter #2 ($subject) of type string is deprecated in file /Smarty_Compiler.class.php line 1531

[Bigbear7]

The strftime deprecation was actually a bit controversial where the RFC author voted against it ;-) Also the benefit of deprecating was debated on the internals list, see: https://externals.io/message/113657

Anyway, is this also an issue for Smarty 3?

[mambax7]

1. Nikita was not the author of it, he just collected the various deprecation requests:

"This is a collection of minor deprecations that various people have put together over the last ~2 years."

2. I don't know about Smarty 3 - we're still using Smarty 2

[Bigbear7]

Well, when checking for the prevalence of strftime in Smarty 3 I found it in the following files:

• /plugins/function.html_select_date.php
• /plugins/modifier.date_format.php
• /Smarty.class.php
• /sysplugins/smarty_internal_config_file_compiler.php
• /sysplugins/smarty_internal_runtime_codeframe.php

Probably the same for Smarty 2.

[wisskid]

Thank you for your report. We'll fix this in due time. But let's get a PHP8.0 release out first :)

[wisskid]

See #678

[mambax7]

@wisskid Thank you!
Now that PHP 8.1 is available, I hope that this update will be available soon too! :)

[mambax7]

I see that 4.x is moving very quickly with PHP 8.1 updates.
When could we expect an update for Smarty 2.x?
Pretty Please? :)

[wisskid]

@mambax7 I have no such intentions, but feel free to provide a PR!

[mambax7]

So is Smarty 2.x now officially "Abandonware"?

[wisskid]

@mambax7 no, Smarty has a v3 and a v4 you could upgrade to.

[mambax7]

I understand that, but is Smarty 2.x now officially "Abandonware"?

[wisskid]

@mambax7 I don't think you can call a specific version "abandonware". But semantics aside: support for v2 has been very limited over the past years and I don't see that improving. Since this is getting off-topic: maybe you could start a Discussion at https://github.com/smarty-php/smarty/discussions if you want to discuss the pros/cons of supporting v2 (and v3?) further into the future?

[mambax7]

This is how I see it:
If 2.x is officially still supported, then this discussion is on-topic, and the original question about update to PHP 8.1 is still valid.

If 2.x is officially not anymore supported, then I agree with you - let's make an official announcement that 2.x is NOT supported anymore, and then people can start a Discussion at https://github.com/smarty-php/smarty/discussions about it

I think, it's important that we have a clear situation and no misunderstandings about the status of 2.x