Use available type information in functional bean definitions for resolving FactoryBean type [SPR-17063]

[spring-projects-issues]

Dave Syer opened SPR-17063 and commented

I encountered a nasty problem with some functional bean registrations, caused by early an instantiation cascade driven from a BeanFactoryPostProcessor in Spring Data. The issue comes back to the BFPP wanting to find bean definitions of a certain type, so it uses BeanFactory.getType(String), which could have used the ResolvableType information that was available for the functional bean definition, but didn't and fell back to instantiating the bean to check its runtime concrete type. The offending code is in AbstractBeanFactory.

---

Issue Links:

• Support for null bean in functional bean registration [SPR-17057] #21595 Support for null bean in functional bean registration
• Publicly expose ResolvableType in RootBeanDefinition [SPR-17028] #21566 Publicly expose ResolvableType in RootBeanDefinition

Referenced from: commits 52d124d

[spring-projects-issues]

Juergen Hoeller commented

AbstractBeanFactory.getType checks RootBeanDefinition.getTargetType() in its regular code path... Did it not end up there for some reason, or was the Class based type information not sufficient for that particular type check attempt?

[spring-projects-issues]

Dave Syer commented

That wasn't working. I think because it is a FactoryBean (makes sense given the Spring Data context - it was looking at LocalEntityManagerFactoryBean).