[6.x] Command palette keys API and display
#12241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng more renderable.
# Conflicts: # resources/js/components/command-palette/CommandPalette.vue
dont need the mental overhead of making the method suitable for public use right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds command palette
keysAPI for displaying hotkeys on actions, etc.Right now this just adds cosmetic badges, using the same keybinding conventions as mousetrap (what we use under the hood with
$keys.bindGlobal(), etc.Do we want the command palette itself to create keybindings, or just continue to display keybindings cosmetically, leaving the actual binding to be created externally?