Skip to content

Conversation

@lemire
Copy link

@lemire lemire commented Jan 3, 2024

With this PR, I am able to get a clean build with ClangCL. The PR does three things:

  1. Instead of trying to compile the snapshot asm directly, it embeds it in cc file using tools/snapshot/asm_to_inline_asm.py. It is how v8 does it.
  2. Visual Studio could not find some libraries with ClangCL when passing /WHOLEARCHIVE:nameoflib so we correct the problem by providing the full path.
  3. We remove the masm builds as they are no longer necessary.

@targos targos merged commit 12c055a into targos:clang-cl Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants