improve docs & error handling for image parts #1569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyphilemon
approved these changes
May 13, 2024
Contributor
|
I think it could be smarter What if you added "if str startsWith (base64) doNothing else add Base64 |
Collaborator
Author
|
@bernaferrari I considered that. There are many variants of this, in particular considering other URLs. The result would be that there are many examples out there for all variants of this method, increasing the maintenance burden and hindering future changes. |
elitan
reviewed
May 25, 2024
| { type: 'text', text: 'Describe the image in detail.' }, | ||
| { | ||
| type: 'image', | ||
| image: new URL( |
Contributor
There was a problem hiding this comment.
the new URL() part was hard to find to get images to work.
Contributor
There was a problem hiding this comment.
was easier to find using github search than here 😅
Contributor
There was a problem hiding this comment.
These changes that are different from openai standard that everywhere is used don't make me happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AI_InvalidDataContentError