-
-
Notifications
You must be signed in to change notification settings - Fork 5
update checkmate #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update checkmate #108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the codebase to use a new checkmate testing framework and adopts a more explicit approach to handling unused function parameters. The changes migrate from using deadnix linter comments to using den.lib.take.unused for marking unused parameters, making the code more self-documenting. The PR also includes formatting improvements and consolidates test files into a new checkmate modules structure.
- Replaces
deadnix: skipcomments with explicitden.lib.take.unusedcalls for better code clarity - Removes unused function parameters across template and module files
- Restructures checkmate tests from standalone test files to a modular checkmate/modules structure with new test files
Reviewed Changes
Copilot reviewed 14 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| templates/default/modules/inputs.nix | Removes unused inputs parameter from module function signature |
| templates/default/modules/aspects/eg/routes.nix | Removes unused eg parameter from module function signature |
| templates/default/modules/aspects/defaults.nix | Replaces deadnix comment with den.lib.take.unused to mark OS parameter as intentionally unused |
| templates/default/modules/aspects/alice.nix | Removes unused __findFile inherit statement and updates comment (orphaned comment issue) |
| nix/den-brackets.nix | Applies formatting convention for multi-line array expressions and removes unnecessary parentheses |
| modules/aspects/provides/unfree.nix | Removes unused aspect-chain parameter from functor |
| modules/aspects/provides/import-tree.nix | Replaces deadnix comment with den.lib.take.unused for aspect-chain parameter |
| modules/aspects/dependencies.nix | Removes unused lib import and home parameter from hmStandaloneDependencies |
| checkmate/modules/function_can_take.nix | Adds new test module for canTake function behavior |
| checkmate/modules/formatter.nix | Adds formatter configuration excluding template files |
| checkmate/modules/den-brackets.nix | Adds new test module for den-brackets functionality |
| checkmate/modules/aspect-functor.nix | Adds new test module for parametric aspect functor behavior |
| checkmate/flake.nix | Removes old checkmate flake configuration |
| checkmate/.gitignore | Removes flake.lock ignore entry |
| checkmate.nix | Removes old checkmate integration file |
| README.md | Updates markdown bold syntax from underscores to asterisks and fixes trailing whitespace |
| .github/workflows/gh-pages.yml | Standardizes to double quotes in YAML strings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| let | ||
| # deadnix: skip # not required, showcasing angle-brackets syntax. | ||
| inherit (den.lib) __findFile; | ||
| # not required, showcasing angle-brackets syntax. # silence nixf linter. |
Copilot
AI
Nov 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] This comment appears to be orphaned and unclear. It mentions "not required, showcasing angle-brackets syntax" and "silence nixf linter" but there's no code immediately after it. Consider either:
- Removing this comment entirely, or
- Moving it closer to the actual usage of angle-bracket syntax (lines 29-30), or
- Clarifying what the comment is referring to
No description provided.