Skip to content

Conversation

@vic
Copy link
Owner

@vic vic commented Nov 21, 2025

No description provided.

@vic vic marked this pull request as ready for review November 21, 2025 04:14
Copilot AI review requested due to automatic review settings November 21, 2025 04:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the codebase to use a new checkmate testing framework and adopts a more explicit approach to handling unused function parameters. The changes migrate from using deadnix linter comments to using den.lib.take.unused for marking unused parameters, making the code more self-documenting. The PR also includes formatting improvements and consolidates test files into a new checkmate modules structure.

  • Replaces deadnix: skip comments with explicit den.lib.take.unused calls for better code clarity
  • Removes unused function parameters across template and module files
  • Restructures checkmate tests from standalone test files to a modular checkmate/modules structure with new test files

Reviewed Changes

Copilot reviewed 14 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
templates/default/modules/inputs.nix Removes unused inputs parameter from module function signature
templates/default/modules/aspects/eg/routes.nix Removes unused eg parameter from module function signature
templates/default/modules/aspects/defaults.nix Replaces deadnix comment with den.lib.take.unused to mark OS parameter as intentionally unused
templates/default/modules/aspects/alice.nix Removes unused __findFile inherit statement and updates comment (orphaned comment issue)
nix/den-brackets.nix Applies formatting convention for multi-line array expressions and removes unnecessary parentheses
modules/aspects/provides/unfree.nix Removes unused aspect-chain parameter from functor
modules/aspects/provides/import-tree.nix Replaces deadnix comment with den.lib.take.unused for aspect-chain parameter
modules/aspects/dependencies.nix Removes unused lib import and home parameter from hmStandaloneDependencies
checkmate/modules/function_can_take.nix Adds new test module for canTake function behavior
checkmate/modules/formatter.nix Adds formatter configuration excluding template files
checkmate/modules/den-brackets.nix Adds new test module for den-brackets functionality
checkmate/modules/aspect-functor.nix Adds new test module for parametric aspect functor behavior
checkmate/flake.nix Removes old checkmate flake configuration
checkmate/.gitignore Removes flake.lock ignore entry
checkmate.nix Removes old checkmate integration file
README.md Updates markdown bold syntax from underscores to asterisks and fixes trailing whitespace
.github/workflows/gh-pages.yml Standardizes to double quotes in YAML strings

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

let
# deadnix: skip # not required, showcasing angle-brackets syntax.
inherit (den.lib) __findFile;
# not required, showcasing angle-brackets syntax. # silence nixf linter.
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] This comment appears to be orphaned and unclear. It mentions "not required, showcasing angle-brackets syntax" and "silence nixf linter" but there's no code immediately after it. Consider either:

  1. Removing this comment entirely, or
  2. Moving it closer to the actual usage of angle-bracket syntax (lines 29-30), or
  3. Clarifying what the comment is referring to

Copilot uses AI. Check for mistakes.
@vic vic merged commit 7c04e8a into main Nov 21, 2025
9 checks passed
@vic vic deleted the checkmate branch November 21, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants