Skip to content

Conversation

@vic
Copy link
Owner

@vic vic commented Oct 29, 2025

No description provided.

Copilot AI review requested due to automatic review settings October 29, 2025 07:34
@vic vic force-pushed the parametric-includes branch from 35c7fa0 to 364da6b Compare October 29, 2025 07:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the aspect dependency system to introduce a new parametric includes mechanism. Instead of directly including dependencies, aspects now define _.host.includes, _.user.includes, and _.home.includes lists that are invoked with the appropriate context parameters. This enables more flexible aspect composition by allowing aspects to be added to specific hosts, users, or homes without modifying the defaults.

Key Changes

  • Refactored hostAspect, userAspect, and homeAspect functions to support parametric includes via aspect._.*.includes attributes
  • Updated comments and documentation to reflect the new invocation pattern
  • Added example showing how to add a parametric aspect to a specific home configuration

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
modules/aspects/dependencies.nix Refactored aspect creation functions to support parametric includes mechanism with _.host.includes, _.user.includes, and _.home.includes
templates/default/modules/_example/aspects.nix Added example demonstrating how to add parametric aspects to specific home configurations
modules/aspects/batteries/home-manager.nix Updated documentation to reflect new syntax for adding home-manager to specific hosts

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vic vic merged commit d1fbc19 into main Oct 29, 2025
3 checks passed
@vic vic deleted the parametric-includes branch October 29, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants