feat(batteries): add user-shell. #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new user-shell module that allows setting a user's default shell at both OS and home-manager levels, with corresponding CI tests to validate the functionality.
- Adds a new reusable
den._.user-shellmodule for configuring user shells across OS and home-manager - Demonstrates usage by configuring "will" user with fish shell in the example configuration
- Adds CI test to verify the shell configuration works correctly
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| modules/aspects/provides/user-shell.nix | New module providing shell configuration functionality for users |
| templates/default/modules/_example/aspects.nix | Example usage applying fish shell to "will" user |
| templates/default/modules/_example/ci.nix | Added CI check to verify user-shell module behavior; added lib parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vic
added a commit
that referenced
this pull request
Nov 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configures user default shell at OS and home level.
darwin support is pending. PR welcome!