feat(batteries): den._.define-user. #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors user and home-manager configuration by extracting the define-user aspect from an example template into a reusable provided aspect. The changes consolidate user definition logic into the den framework's provides system, making it more accessible and maintainable.
Key changes:
- Creates a new
modules/aspects/provides/define-user.nixfile that centralizes user and home directory configuration logic - Updates the example template to reference the new provided aspect instead of defining the logic inline
- Adds documentation on how to use the
define-useraspect for both users and standalone-homes
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| modules/aspects/provides/define-user.nix | Introduces a new provided aspect for defining users at OS and Home Manager levels with support for both NixOS and Darwin systems |
| templates/default/modules/_example/aspects.nix | Removes local user definition logic and updates to use the centralized den._.define-user aspect |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vic
added a commit
that referenced
this pull request
Nov 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.