A template (den) for bug reproduction. #50
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new "bogus" template for bug reproduction, updates the default template to use the GitHub repository instead of a local path, and refactors the provides.nix module to use config.den.lib.aspects instead of inputs.flake-aspects.lib.
- Added a new
bogustemplate with complete bug reproduction scaffolding including test infrastructure - Changed the default template's
deninput from a local path to the GitHub repository - Refactored code documentation and formatting instructions in the README
Reviewed Changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/default/flake.nix | Updated den input from local path to GitHub repository |
| templates/default/flake.lock | Updated lock file to reflect GitHub source for den |
| templates/bogus/modules/test-base.nix | Added base test configuration for bug reproduction |
| templates/bogus/modules/nix-unit.nix | Added nix-unit test configuration |
| templates/bogus/modules/formatter.nix | Added code formatting configuration |
| templates/bogus/modules/flakes.nix | Added flake inputs configuration for bug reproduction |
| templates/bogus/modules/dendritic.nix | Added dendritic flake-file integration |
| templates/bogus/modules/bug.nix | Added example bug reproduction with test assertions |
| templates/bogus/flake.nix | Added auto-generated flake file for bogus template |
| templates/bogus/flake.lock | Added lock file for bogus template |
| templates/bogus/README.md | Added documentation for using the bug reproduction template |
| modules/aspects/provides.nix | Refactored to use config.den.lib instead of inputs.flake-aspects.lib |
| flake.nix | Restructured templates definition and added bogus template |
| README.md | Updated documentation with formatting instructions and bug reporting guidance |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 13 out of 15 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 13 out of 15 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| users.users.tux.packages = [ pkgs.hello ]; | ||
| }; | ||
|
|
||
| # rename "it works", evidently it has bugs |
There was a problem hiding this comment.
Inconsistent comment style: The comment says 'rename "it works"' but the test is named "test it works". This appears to be placeholder text that should be updated to match the actual test name or provide clearer guidance. Consider changing to: # Replace "test it works" with a descriptive name for your test or similar.
| # rename "it works", evidently it has bugs | |
| # Replace "test it works" with a descriptive name for your test |
| matrix: | ||
| os: [ubuntu-latest, macos-latest] | ||
| name: Nix flake check | ||
| runs-on: ${{matrix.os}} |
There was a problem hiding this comment.
Inconsistent spacing in YAML: runs-on: ${{matrix.os}} should have spaces around the expression for consistency with GitHub Actions best practices. Consider changing to runs-on: ${{ matrix.os }}.
| runs-on: ${{matrix.os}} | |
| runs-on: ${{ matrix.os }} |
No description provided.