Standalone home and other changes #7

HeitorAugustoLN · 2025-10-25T00:21:50Z

Closes #5

Copilot

Pull Request Overview

This PR introduces support for standalone home-manager configurations in den, allowing users to define home environments independent of NixOS/Darwin host configurations. The key structural change is moving host definitions under den.hosts (from den) and adding a new den.homes option for standalone home configurations.

Key Changes:

Added standalone home-manager configuration support via den.homes
Refactored host definitions to be nested under den.hosts instead of directly under den
Added input name override capabilities for nixpkgs, darwin, and home-manager dependencies

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
templates/default/modules/_example/hosts.nix	Updated to use new `den.hosts` path for host definitions
templates/default/modules/_example/homes.nix	New example file demonstrating standalone home-manager configurations
nix/types.nix	Added `homesOption`, `homeType`, and `inputsOption` types; renamed `denOption` to `hostsOption`
nix/os-config.nix	Updated to use `config.den.hosts` and support input name overrides
nix/home-config.nix	New file implementing standalone home-manager configuration instantiation
nix/flakeModule.nix	Added new imports and options for homes and inputs configuration
nix/aspects-config.nix	Extended aspect system to support standalone homes alongside hosts
README.md	Added documentation for standalone home-manager configurations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

README.md

Copilot

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

nix/types.nix

Copilot

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

vic

wow ! looks awesome!

I left some changes request, thank you again :)

nix/aspects-config.nix

nix/types.nix

nix/flakeModule.nix

nix/home-config.nix

Copilot

Pull Request Overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-25T13:10:56Z

templates/default/flake.nix

+      inputs = {
+        nixpkgs = {
+          follows = "nixpkgs";
+        };
+      };
+      url = "github:nix-community/home-manager";


[nitpick] The url attribute should be defined before the inputs attribute for better readability and consistency with Nix conventions. Move line 26 to line 20.

Suggested change

inputs = {

nixpkgs = {

follows = "nixpkgs";

};

};

url = "github:nix-community/home-manager";

url = "github:nix-community/home-manager";

inputs = {

nixpkgs = {

follows = "nixpkgs";

};

};

Copilot · 2025-10-25T13:10:56Z

nix/os-config.nix

+  config,
  inputs,
  lib,
-  config,
+  self,


[nitpick] The parameter order has been changed from alphabetical (config, inputs, lib) to (config, inputs, lib, self). Consider maintaining alphabetical ordering for consistency: (config, inputs, lib, self) is already correct, but the original order (inputs, lib, config) suggests a different convention may have been in use. Ensure this change aligns with project conventions.

- Rename denOption to hostsOption in types.nix - Change options.den to options.den.hosts in flakeModule.nix - Update all references to use config.den.hosts instead of config.den

Copilot

Pull Request Overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Add den.homes option for standalone home-manager configurations - Create home-config.nix to instantiate homeConfigurations - Add homeType and homesOption to types.nix - Extend aspects-config.nix with homeAspect and default.home - Add example homes.nix template

Allow arbitrary additional attributes beyond defined options

Copilot

Pull Request Overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

vic · 2025-10-25T19:48:52Z

Thank you, @HeitorAugustoLN

Copilot AI review requested due to automatic review settings October 25, 2025 00:21

Copilot AI reviewed Oct 25, 2025

View reviewed changes

README.md Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings October 25, 2025 00:26

Copilot AI reviewed Oct 25, 2025

View reviewed changes

HeitorAugustoLN commented Oct 25, 2025

View reviewed changes

nix/types.nix Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings October 25, 2025 00:44

HeitorAugustoLN force-pushed the standalone-home branch from d5b474f to ebaf088 Compare October 25, 2025 00:44

Copilot AI reviewed Oct 25, 2025

View reviewed changes

HeitorAugustoLN force-pushed the standalone-home branch from ebaf088 to 7c6fb07 Compare October 25, 2025 00:52

vic requested changes Oct 25, 2025

View reviewed changes

nix/aspects-config.nix Outdated Show resolved Hide resolved

nix/types.nix Show resolved Hide resolved

nix/flakeModule.nix Show resolved Hide resolved

nix/home-config.nix Show resolved Hide resolved

Copilot AI review requested due to automatic review settings October 25, 2025 13:10

HeitorAugustoLN force-pushed the standalone-home branch from 7c6fb07 to fb4587c Compare October 25, 2025 13:10

Copilot AI reviewed Oct 25, 2025

View reviewed changes

refactor: move host options from config.den to config.den.hosts

66ebf5b

- Rename denOption to hostsOption in types.nix - Change options.den to options.den.hosts in flakeModule.nix - Update all references to use config.den.hosts instead of config.den

HeitorAugustoLN force-pushed the standalone-home branch from fb4587c to fd47779 Compare October 25, 2025 13:15

Copilot AI review requested due to automatic review settings October 25, 2025 13:17

HeitorAugustoLN force-pushed the standalone-home branch from fd47779 to 6fe6a87 Compare October 25, 2025 13:17

Copilot AI reviewed Oct 25, 2025

View reviewed changes

HeitorAugustoLN force-pushed the standalone-home branch from 6fe6a87 to 38755de Compare October 25, 2025 13:19

HeitorAugustoLN added 3 commits October 25, 2025 10:27

feat(types): add freeformType to host, user, and home types

2789035

Allow arbitrary additional attributes beyond defined options

docs(README): fix standalone home system typo

3173523

Copilot AI review requested due to automatic review settings October 25, 2025 13:27

HeitorAugustoLN force-pushed the standalone-home branch from 38755de to 3173523 Compare October 25, 2025 13:27

Copilot AI reviewed Oct 25, 2025

View reviewed changes

vic merged commit ee16877 into vic:main Oct 25, 2025
2 checks passed

HeitorAugustoLN deleted the standalone-home branch October 25, 2025 20:13

Uh oh!

Standalone home and other changes #7

Standalone home and other changes #7

Uh oh!

Conversation

HeitorAugustoLN commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

vic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

vic commented Oct 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

HeitorAugustoLN commented Oct 25, 2025 •

edited

Loading