reorg test examples #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vic
force-pushed
the
examples
branch
2 times, most recently
from
6948116 to
079b023
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR reorganizes test examples by splitting large monolithic files (ci.nix and aspects.nix) into smaller, focused modules within a new ci/ subdirectory. This improves code organization and maintainability by separating different test scenarios and configuration examples into individual files.
- Refactored test infrastructure by moving CI checks and helper functions into separate modules
- Split configuration aspects into individual example files organized by feature (user-shell, primary-user, unfree, etc.)
- Relocated home-manager input configuration from
homes.nixtohome-managed.nixfor better logical grouping
Reviewed Changes
Copilot reviewed 25 out of 27 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/examples/modules/_example/vm.nix | Removed entire file containing VM package definition |
| templates/examples/modules/_example/homes.nix | Removed home-manager input declarations (moved elsewhere) |
| templates/examples/modules/_example/home-managed.nix | Added home-manager dependency configuration |
| templates/examples/modules/_example/defaults.nix | Removed homeManager.programs.fish.enable default setting |
| templates/examples/modules/_example/ci/vm-bootable.nix | New file with VM bootable configuration example |
| templates/examples/modules/_example/ci/user-specific-hm-config.nix | New file demonstrating user-specific home-manager config |
| templates/examples/modules/_example/ci/user-shell.nix | New file with user shell configuration example |
| templates/examples/modules/_example/ci/user-host-conditional-os.nix | New file showing conditional OS config based on user/host |
| templates/examples/modules/_example/ci/user-home-defaults.nix | New file with home defaults configuration |
| templates/examples/modules/_example/ci/user-configures-hosts.nix | New file demonstrating users configuring hosts |
| templates/examples/modules/_example/ci/unfree.nix | New file with unfree package configuration example |
| templates/examples/modules/_example/ci/standalone-hm-special-args-osconfig.nix | New file showing standalone home-manager with osConfig access |
| templates/examples/modules/_example/ci/set-hostname.nix | New file with hostname configuration example |
| templates/examples/modules/_example/ci/primary-user.nix | New file with primary user configuration |
| templates/examples/modules/_example/ci/one-os-package-per-user.nix | New file demonstrating per-user package configuration |
| templates/examples/modules/_example/ci/import-tree.nix | Updated to add test checks for auto-import functionality |
| templates/examples/modules/_example/ci/host-user-conditional-hm.nix | New file with conditional home-manager config |
| templates/examples/modules/_example/ci/host-configures-users.nix | New file showing hosts configuring users |
| templates/examples/modules/_example/ci/helpers.nix | New file with CI helper functions and configuration references |
| templates/examples/modules/_example/ci/enable-wsl-host.nix | New file with WSL host configuration |
| templates/examples/modules/_example/ci/define-user.nix | New file with user definition example |
| templates/examples/modules/_example/ci/custom-nixos-module.nix | New file with custom NixOS module example |
| templates/examples/modules/_example/ci/builds.nix | New file with build checks for CI |
| templates/examples/modules/_example/ci/_non_dendritic/hosts/rockhopper/_nixos/hardware-auto-generated.nix | New file with auto-generated hardware config for testing |
| templates/examples/modules/_example/ci/_non_dendritic/hosts/honeycrisp/_darwin/something.nix | New file with Darwin configuration placeholder |
| templates/examples/modules/_example/ci.nix | Removed entire file (split into multiple smaller files) |
| templates/examples/modules/_example/aspects.nix | Removed entire file (split into multiple smaller files) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #73