-
-
Notifications
You must be signed in to change notification settings - Fork 5
example namespaces and angle-brackets in default template. #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the default template to use a namespace-based organization, splitting the monolithic den.nix and dendritic.nix files into a more modular, dendritic structure with dedicated files for different concerns.
- Introduces an
eg(example) namespace for organizing aspects - Splits configuration into focused modules (inputs, namespace, aspects, CI)
- Reorganizes aspects into separate files under
modules/aspects/andmodules/aspects/eg/
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/default/modules/namespace.nix | Creates the new eg namespace using den's namespace function |
| templates/default/modules/inputs.nix | Extracts flake inputs from dendritic.nix (home-manager, darwin, commented WSL inputs) |
| templates/default/modules/dendritic.nix | Simplified to only import the dendritic flake module |
| templates/default/modules/den.nix | Reduced to minimal host/home definitions, with aspects moved to separate files |
| templates/default/modules/ci.nix | New module to set CI flag for conditional configurations |
| templates/default/modules/aspects/igloo.nix | Extracts igloo host configuration using the eg namespace |
| templates/default/modules/aspects/eg/xfce-desktop.nix | Non-parametric XFCE desktop aspect in eg namespace |
| templates/default/modules/aspects/eg/vm-bootable.nix | VM installer aspect in eg namespace |
| templates/default/modules/aspects/eg/ci-no-boot.nix | CI boot disabling aspect in eg namespace |
| templates/default/modules/aspects/eg/autologin.nix | Parametric autologin aspect in eg namespace |
| templates/default/modules/aspects/defaults.nix | Global defaults and includes configuration |
| templates/default/modules/aspects/alice.nix | Alice user configuration using eg namespace |
| templates/default/README.md | Getting started guide documenting the new structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
use angle brackets in default.nix demo
|
@xdbr guess what !? Looks like you discovered a bug, haha. Because there was no test exercising the angle brackets syntax. So I just updated our default template in this PR and it uncovered a bug that angle-brackets did not correctly handled namespaces. Fix is already in this commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@vic well... i'm happy to help ;) after all, there seems to be value in being an early adopter – plus you get front-row seats ;) looking forward to your fix! |
already merged, angle-brackets should work now with namespaces. I'm not sure about your |
|
Sadly, even after pulling the latest update (through Some questions and observations:
|
Ah I see – just to mention, I haven't used |
The boolean enables the flake output, use
Yep. See
It is currently experimental, meaning I don't know how well it will play in the long run. That is why it is enabled explicitly by the user at the module level. I would even recommend not using it module-level (as a module arg) but instead a as a let-binding (see alice.nix) |
|
I'm adding yet more checks to the default template regarding angle brackets. Just wanted to say, thank you for using den <3, and discovering tests I'm missing, I'll add a couple just to make sure it must work for you. |
|
I'm just genuinely happy to see such a great and well-thought out library/framework (i.e. also including flake-aspects, etc) in this problem space :) – in my opinion this is next-gen stuff and one of the best inventions since sliced bread (as we like to say around here). I'm really looking forward to checking out your latest developments first thing tomorrow morning. Keep cracking, I can't wait! |
split into several files, more dendritic.