Skip to content

Conversation

@vic
Copy link
Owner

@vic vic commented Oct 26, 2025

host and home options now allow setting a custom instantiate function to allow overriding the input or the function used to build the OS/home if people really need things like specialArgs

host and home options now allow setting a custom instantiate function
to allow overriding the input or the function used to build the OS/home
if people **really** need things like specialArgs
Copilot AI review requested due to automatic review settings October 26, 2025 07:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the configuration system to support customizable input sources and instantiation functions for different system types. It adds support for system-manager alongside nixos and darwin, while allowing users to override default inputs and build functions when needed.

Key changes:

  • Added instantiate and intoAttr options to both host and home configurations for flexible input sources
  • Consolidated separate os-config.nix and home-config.nix into a unified config.nix
  • Added system-manager as a supported host class with corresponding defaults

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
nix/types.nix Added instantiate and intoAttr options with defaults for nixos, darwin, systemManager, and homeManager classes
nix/os-config.nix Removed file - functionality merged into config.nix
nix/home-config.nix Removed file - functionality merged into config.nix
nix/flakeModule.nix Updated imports to use new consolidated config.nix and aspects.nix files
nix/config.nix New unified configuration builder supporting both OS and home configurations with customizable instantiation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vic
Copy link
Owner Author

vic commented Oct 26, 2025

regarding specialArgs, @HeitorAugustoLN.

Copilot AI review requested due to automatic review settings October 26, 2025 07:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vic
Copy link
Owner Author

vic commented Oct 26, 2025

For example some people (like me) that do use homeManager inside a nixos configuration would still like to have a homeConfiguration.vic@host so that it can be applied without re-building the whole OS. see: mightyiam/dendritic#11 (reply in thread)

@vic vic merged commit 2480d18 into main Oct 26, 2025
2 checks passed
@vic vic deleted the instantiate branch October 26, 2025 08:27
@HeitorAugustoLN
Copy link
Contributor

How does adding specialArgs work?

@vic
Copy link
Owner Author

vic commented Oct 26, 2025

I've just documented it at README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants