-
-
Notifications
You must be signed in to change notification settings - Fork 5
support different inputs for nixpkgs, darwin. also add systemManager. #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
host and home options now allow setting a custom instantiate function to allow overriding the input or the function used to build the OS/home if people **really** need things like specialArgs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the configuration system to support customizable input sources and instantiation functions for different system types. It adds support for system-manager alongside nixos and darwin, while allowing users to override default inputs and build functions when needed.
Key changes:
- Added
instantiateandintoAttroptions to both host and home configurations for flexible input sources - Consolidated separate os-config.nix and home-config.nix into a unified config.nix
- Added system-manager as a supported host class with corresponding defaults
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| nix/types.nix | Added instantiate and intoAttr options with defaults for nixos, darwin, systemManager, and homeManager classes |
| nix/os-config.nix | Removed file - functionality merged into config.nix |
| nix/home-config.nix | Removed file - functionality merged into config.nix |
| nix/flakeModule.nix | Updated imports to use new consolidated config.nix and aspects.nix files |
| nix/config.nix | New unified configuration builder supporting both OS and home configurations with customizable instantiation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
regarding specialArgs, @HeitorAugustoLN. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
For example some people (like me) that do use homeManager inside a nixos configuration would still like to have a |
|
How does adding specialArgs work? |
|
I've just documented it at README. |
host and home options now allow setting a custom instantiate function to allow overriding the input or the function used to build the OS/home if people really need things like specialArgs