Skip to content

Conversation

@vic
Copy link
Owner

@vic vic commented Nov 13, 2025

Edit modules/vm.nix

Closes #82

@vic vic marked this pull request as ready for review November 13, 2025 12:07
Copilot AI review requested due to automatic review settings November 13, 2025 12:07
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the VM configuration to enable switching between GUI and console (TUI) variants. The main change introduces a modular structure where VM configurations can be composed with either graphical or text-based installers, making it easy to toggle between modes by commenting/uncommenting a single line.

  • Refactored eg.vm-bootable to provide both gui and graphical-base variants using a parameterized installer function
  • Created new eg.vm aspect that composes VM configurations with appropriate bootable installers and desktop environments
  • Moved VM variant selection from igloo.nix to a centralized configuration in vm.nix

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
templates/default/modules/vm.nix Added parameters and configured to use eg.vm._.gui variant (with tui option commented out)
templates/default/modules/aspects/igloo.nix Removed hardcoded VM and desktop includes, delegated to vm.nix
templates/default/modules/aspects/eg/vm.nix New file defining composable VM variants (gui/tui) with appropriate bootable installers
templates/default/modules/aspects/eg/vm-bootable.nix Refactored to use parameterized installer function supporting minimal (tui) and graphical-base (gui) variants
templates/default/modules/aspects/defaults.nix Added OS parameter with deadnix skip annotation for compatibility
templates/default/flake.lock Updated den dependency to newer version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vic vic merged commit 0b4cbcd into main Nov 13, 2025
@vic vic deleted the tui branch November 13, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce the assumptions in the default template

2 participants