Skip to content

Conversation

@vic
Copy link
Owner

@vic vic commented Nov 14, 2025

Fixes #89

@vic vic marked this pull request as ready for review November 14, 2025 11:51
Copilot AI review requested due to automatic review settings November 14, 2025 11:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the aspect definition system to enable proper evaluation of home-manager aspects that are shared between OS-integrated and standalone configurations without conflicts. The refactoring unifies the previously separate aspect creation functions and ensures consistent parameter passing throughout the codebase.

Key changes:

  • Unified aspect creation from three separate functions (homeAspect, hostAspect, userAspect) into a single makeAspect function with consistent behavior
  • Updated parameter passing to include user and home contexts where needed for proper aspect resolution
  • Introduced a new mainModule helper function in _types.nix to properly resolve aspects with the correct context

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
templates/default/modules/den.nix Uncommented the standalone home-manager configuration to enable testing of the new aspect evaluation
modules/aspects/provides/home-manager.nix Added user parameter to context inheritance to ensure user information is available for aspect resolution
modules/aspects/dependencies.nix Added user parameter to aspect invocation for consistent context passing in OS user dependencies
modules/aspects/definition.nix Refactored aspect creation to use unified makeAspect function and streamlined the dependency collection pipeline
modules/_types.nix Added mainModule helper function and updated both host and home type definitions to use it for consistent module resolution

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vic vic merged commit 5b49190 into main Nov 14, 2025
14 of 17 checks passed
@vic vic deleted the shared branch November 14, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Having Standalone hm and OS hm with same aspect name causes duplicate definitions.

2 participants