use parametric.atLeast instead of parametric true
#94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the codebase to use the more explicit parametric.atLeast API instead of the boolean-based parametric true syntax. According to the parametric.__functor implementation, passing true to parametric returns parametric.atLeast, so this change is functionally equivalent but improves code clarity and maintainability.
- Replaces all instances of
parametric truewithparametric.atLeast - Updates three files: two production modules and one test file
- Uses explicit API method instead of boolean-based syntax
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| modules/aspects/provides/define-user.nix | Updated __functor to use explicit parametric.atLeast |
| modules/aspects/defaults.nix | Updated __functor to use explicit parametric.atLeast |
| checkmate/tests/aspect-functor.nix | Updated test example to use explicit parametric.atLeast |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.