Skip to content

Conversation

@jugglinmike
Copy link

@jugglinmike jugglinmike commented Sep 7, 2019

In 2015, the "popup" value of the <menu> element's type attribute
was renamed to "context" [1]. In 2017, the <menuitem> element and the
type attribute of the <menu> element were removed entirely [2].

Remove the rows that describe these features.

[1] whatwg/html#241
[2] whatwg/html#2742

This patch seems incomplete to me because it does not introduce any mapping for the <menu> element. Although I would intuitively expect the mapping to be to WAI-ARIA "menu" across the board, it doesn't seem as though this was originally specified.

At the time the value "popup" was changed to "context" (see the first pull request listed above) the spec read:

The attribute may also be omitted. The missing value default is the "popup menu" state if the parent element is a menu element whose type attribute is in the "popup menu" state; otherwise, it is the "toolbar" state.

So as far as I can tell, since this table never defined a mapping for <menu="toolbar">, it likewise never defined a mapping for a "bare" <menu>.

This patch persists references to the menuitem role. I don't know if the change in HTML has any bearing on that role, but I thought this would be a sensible first step in any case.

The following tasks have been completed:

Implementation commitment:

/cc @zcorpan


Preview | Diff

In 2015, the "popup" value of the `<menu>` element's `type` attribute
was renamed to "context" [1]. In 2017, the `<menuitem>` element and the
`type` attribute of the `<menu>` element were removed entirely [2].

Remove the rows that describe these features.

[1] whatwg/html#241
[2] whatwg/html#2742
@ylafon
Copy link
Member

ylafon commented Sep 7, 2019

Marked as non substantive for IPR from ash-nazg.

@scottaohara
Copy link
Member

scottaohara commented Sep 7, 2019

hey there @jugglinmike, seems you've overlapped with work I had been doing in #214 to close #188.

Presently there are no browsers that do anything useful with mapping for a bare menu, but as it's an element defined in the HTML spec, we can't just remove it.

Currently in my PR I have menu set to map to role=list since the HTML specification notes that it should be considered like a ul. However bugs need to be filed with browsers and they need to commit to mapping the element as a list before I can pull in #214.

@scottaohara
Copy link
Member

issue #188 was merged in closing #214.

closing this PR as duplicative.

@jugglinmike
Copy link
Author

Hey @scottaohara! Clearly, I skipped an important part of FOSS development--searching the issue tracker. Glad to know someone's a step ahead on this :)

@scottaohara
Copy link
Member

no worries, it was still appreciated. very happy to receive any other PRs for open issues though :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants