Delete rows for removed feature #237
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2015, the "popup" value of the
<menu>element'stypeattributewas renamed to "context" [1]. In 2017, the
<menuitem>element and thetypeattribute of the<menu>element were removed entirely [2].Remove the rows that describe these features.
[1] whatwg/html#241
[2] whatwg/html#2742
This patch seems incomplete to me because it does not introduce any mapping for the
<menu>element. Although I would intuitively expect the mapping to be to WAI-ARIA "menu" across the board, it doesn't seem as though this was originally specified.At the time the value "popup" was changed to "context" (see the first pull request listed above) the spec read:
So as far as I can tell, since this table never defined a mapping for
<menu="toolbar">, it likewise never defined a mapping for a "bare"<menu>.This patch persists references to the
menuitemrole. I don't know if the change in HTML has any bearing on that role, but I thought this would be a sensible first step in any case.The following tasks have been completed:
Implementation commitment:
/cc @zcorpan
Preview | Diff