Issue 188: Remove and update menuitems and menu mappings #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menuitem type=radio, checkbox and command have been removed as they are not in the HTML spec
Remove additional elements that “mapped” to `menuitem` as this element is not in the living standard specification. * `a` with parent `menu` * `button` with parent `menu` * `input type=checkbox` with parent `menu` * `input type=image` with parent `menu` * `input type=radio` with parent `menu`
the `menuitem` element is not part of the Living Standard and the following attributes have been updated to remove references to `menuitem`. * indeterminate idl referencing `menuitem` * `checked` referencing `menuitem` types * `disabled` referencing `menuitem` * removed attr `icon` for `menuitem` element * `label` referencing `menu` and `menuitem` elements * `type` referencing `menuitem` * removed attr `radiogroup` for `menuitem` element * `title` for `menuitem` element
Per the HTML Living Standard, `<menu>` is a semantic alternative to `ul` to express an unordered list of commands. There is (presently) no special mappings / specification definition for `li`s within a `menu`.
scottaohara
changed the title
stevefaulkner
requested changes
Jun 18, 2019
stevefaulkner
approved these changes
Jul 10, 2019
Member
Author
|
Added "not ready for merge" label as there are some issues that need to be addressed outside of this PR before merging. |
Member
Author
|
Adding todo item of adding a link in the comment section for |
5 tasks
link to HTML obsolete section for `menu type=` and `menuitem` update date of change for changelog
Member
Author
|
latest push completes todo to reference/link to obsolete |
stevefaulkner
approved these changes
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #188
removed element mappings for:
removed attribute mappings for:
menu updated to map to role=list
Preview | Diff