Update cross references to HTML. #514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ument" The notion of "list of descendant browsing contexts" also needed to be replaced by "descendant navigables". This was not reported by ReSpec because the previous term was not exported by HTML so it was defined locally in the Terminology section. Good news is "descendant navigables" is exported, so we can link to it directly. It seems a pity to lose the link to "unload a document" just because HTML no longer export the term. This update adds it back as a local definition that links to the (private for now) definition in HTML. We'll need to check that list of terms at some point and exchange with HTML editors to see whether they could export them, think we're doing something wrong, or think we should continue with the current setting.
tidoust
approved these changes
Jan 19, 2023
Member
There was a problem hiding this comment.
I took the liberty to push an update. The "list of descendant browsing contexts" also needed to be replaced by "descendant navigables", which also has the benefit to be exported by the HTML spec.
Also, I think we should keep a link to the notion of "unload a document", even though the HTML spec no longer exports that notion, since it helps clarify what implementations should do.
Contributor
Author
|
Thanks @tiidoust. This looks good to me. |
github-actions bot
added a commit
that referenced
this pull request
Jan 19, 2023
SHA: e7f2d4d Reason: push, by mfoltzgoogle Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Issue #509 for background. This PR is intended to fix the current crop of ReSpec errors and warnings.
WhatWG HTML makes the following recommendation,
In the future we may want to update the spec to refer to current concepts like navigables and traversables, instead of browsing contexts. However that is out of scope for right now.
Preview | Diff